fix(tests): resolve flaky acceptance tests (app creation, human eval, prompt registry, members invite)#4458
Open
bekossy wants to merge 2 commits into
Open
fix(tests): resolve flaky acceptance tests (app creation, human eval, prompt registry, members invite)#4458bekossy wants to merge 2 commits into
bekossy wants to merge 2 commits into
Conversation
…egistry, and members
- app/test.ts: use force:true on popover item click — the CreateAppDropdown
re-renders when appTemplatesQueryAtom resolves, making the button briefly
unstable; force bypasses Playwright's stability check that was retrying to
the 60 s test timeout
- human-annotation/tests.ts: fix TOCTOU race in getHumanEvaluationCreateButton
— cache the found button inside the expect.poll callback so the second
getVisibleButtonByLabels call (which could race a re-render) is eliminated
- prompt-registry/index.ts: poll for ANY visible published revision row instead
of hardcoding revisions[0].id — the completion app accumulates revisions
across runs; with virtual scrolling the first revision from the API response
may not be in the DOM viewport
- members/index.ts: remove waitForLoadState("networkidle") from invitePendingMember
and WEB-ACC-MEMBERS-002 — pages with polling never reach networkidle, consuming
up to 30 s of the 60 s budget; wait directly for the email input which is the
correct signal that the dynamic() InviteUsersModal chunk has rendered; raise
timeout to 90 s for tests 003/004 that run the full invite flow as setup
- deployment/index.ts: skip skeleton rows in row selector, extend row timeout
- observability/index.ts: increase test timeouts to 300 s, improve polling loop
- playground/index.ts: wait for Compare button to be enabled before clicking
- apiHelpers/index.ts: exclude evaluator apps when resolving completion app type
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
dosubot
Bot
added
size:XS
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR bumps the project version from 0.100.3 to 0.100.4 across all packages (backend services, Python clients/SDKs, Kubernetes Helm chart, and web packages), alongside targeted Playwright test flakiness fixes to replace timing-based waits with explicit UI readiness checks, and updates the app type filter to exclude evaluator apps from the completion type. ChangesRelease 0.100.4 and Stabilization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Railway Preview Environment
Updated at 2026-05-27T17:27:04.579Z |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
force:trueon Popover item click to bypass re-render instability fromappTemplatesQueryAtomresolving post-mount, which briefly detaches the dropdown item from the DOMexpect.pollto eliminate a TOCTOU race where the button disappears between the poll succeeding and the second lookupwaitForLoadState("networkidle")(stalls indefinitely on pages with polling/WebSockets) with a targeted wait for the email input; increase timeout to 90 s for tests that run a full invite flow as setup; wait for the dynamic-importedInviteUsersModalform body (not just the dialog wrapper) before fillingPre-existing staged changes also included:
Test plan
members.spec.ts— "should resend an invitation and confirm success" should pass consistentlyapp/index.ts— "creates new chat prompt app" should pass consistentlyhuman-annotation/index.ts— WEB-ACC-HUMAN-001 should pass consistentlyprompt-registry/index.ts— "should open prompt details from prompt registry" should pass consistently🤖 Generated with Claude Code