[codex] fix auth preflight and otp state#4460
Draft
jp-agenta wants to merge 1 commit into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This fixes two auth-side issues: protected project queries now wait for a usable token, and the auth page resets an invalid OTP-visible state that could hide the email form.
It also adds a defensive
fetchAllProjects()guard so project fetches return early when no token is available yet.Why
On reload, the app could issue protected requests before SuperTokens had made an access token available, leading to unauthenticated
/api/projectscalls. Separately, the auth page could land in a state where OTP UI visibility hid the email entry form before an email had actually been submitted.Impact
Protected project queries should no longer fire prematurely during auth refresh, and the auth page should no longer show a blank area under the social login divider.
Validation