NN clusterizer: Fixing memory access faults #14657

ChSonnabend · 2025-09-05T18:45:30Z

No description provided.

github-actions · 2025-09-05T18:45:42Z

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

alibuild · 2025-09-05T19:33:39Z

Error while checking build/O2/fullCI_slc9 for 4998576 at 2025-09-05 21:33:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:94:11: error: 'info' was not declared in this scope
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:94:7: error: 'LOG' was not declared in this scope
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:109:9: error: 'info' was not declared in this scope
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:109:5: error: 'LOG' was not declared in this scope
make[2]: *** [GPU/GPUTracking/CMakeFiles/GPUTracking.dir/build.make:1147: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/TPCClusterFinder/GPUTPCNNClusterizer.cxx.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:705: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Full log here.

alibuild · 2025-09-05T21:52:41Z

Error while checking build/O2/fullCI_slc9 for 5368d52 at 2025-09-05 23:52:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:72:28: error: aggregate 'std::ostringstream os' has incomplete type and cannot be defined
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:74:57: error: 'setprecision' is not a member of 'std'
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:105:37: error: 'setprecision' is not a member of 'std'
make[2]: *** [GPU/GPUTracking/CMakeFiles/GPUTracking.dir/build.make:1147: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/TPCClusterFinder/GPUTPCNNClusterizer.cxx.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:705: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Full log here.

…ins out-of-bounds accesses and memory faults

…out-of-bounds in QC anymore

Please consider the following formatting changes to AliceO2Group#14657

alibuild · 2025-09-06T23:03:46Z

Error while checking build/O2/fullCI_slc9 for 0ed462e at 2025-09-07 01:03:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.cxx:61:81: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int32_t' {aka 'int'} [-Werror=sign-compare]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.cxx:275:81: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int32_t' {aka 'int'} [-Werror=sign-compare]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.cxx:295:81: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int32_t' {aka 'int'} [-Werror=sign-compare]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.cxx:334:15: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int32_t' {aka 'int'} [-Werror=sign-compare]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.cxx:456:15: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int32_t' {aka 'int'} [-Werror=sign-compare]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.cxx:614:81: error: comparison of integer expressions of different signedness: 'uint32_t' {aka 'unsigned int'} and 'int32_t' {aka 'int'} [-Werror=sign-compare]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:72:28: error: aggregate 'std::ostringstream os' has incomplete type and cannot be defined
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:74:57: error: 'setprecision' is not a member of 'std'
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:137:37: error: 'setprecision' is not a member of 'std'
make[2]: *** [GPU/GPUTracking/CMakeFiles/GPUTracking.dir/build.make:1147: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/TPCClusterFinder/GPUTPCNNClusterizer.cxx.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [GPU/GPUTracking/CMakeFiles/GPUTracking.dir/build.make:1133: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/TPCClusterFinder/GPUTPCNNClusterizerKernels.cxx.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:705: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Full log here.

alibuild · 2025-09-07T09:14:31Z

Error while checking build/O2/fullCI_slc9 for 902ddc6 at 2025-09-07 11:14:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:72:28: error: aggregate 'std::ostringstream os' has incomplete type and cannot be defined
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:74:57: error: 'setprecision' is not a member of 'std'
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:137:37: error: 'setprecision' is not a member of 'std'
make[2]: *** [GPU/GPUTracking/CMakeFiles/GPUTracking.dir/build.make:1147: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/TPCClusterFinder/GPUTPCNNClusterizer.cxx.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:705: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Full log here.

alibuild · 2025-09-07T10:07:50Z

Error while checking build/O2/fullCI_slc9 for 79cc38e at 2025-09-07 12:07:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizer.cxx:138:37: error: 'setprecision' is not a member of 'std'
make[2]: *** [GPU/GPUTracking/CMakeFiles/GPUTracking.dir/build.make:1147: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/TPCClusterFinder/GPUTPCNNClusterizer.cxx.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:705: GPU/GPUTracking/CMakeFiles/GPUTracking.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Full log here.

alibuild · 2025-09-07T18:50:54Z

Error while checking build/O2/fullCI_slc9 for b50afbb at 2025-09-07 23:08:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1326: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_fillInputNNCPU.hip.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1313: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_runCfClusterizer.hip.o] Error 1
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1365: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_determineClass2Labels.hip.o] Error 1
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1339: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_fillInputNNGPU.hip.o] Error 1
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1378: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_publishClass1Regression.hip.o] Error 1
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1352: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_determineClass1Labels.hip.o] Error 1
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1391: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_publishClass2Regression.hip.o] Error 1
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1404: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_publishDeconvolutionFlags.hip.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1175: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:136: all] Error 2

Full log here.

alibuild · 2025-09-07T22:13:58Z

Error while checking build/O2/fullCI_slc9 for 1d02b30 at 2025-09-08 03:25:

No log files found

Full log here.

ChSonnabend · 2025-09-08T06:17:47Z

@davidrohr : ready once the CI is green.

davidrohr · 2025-09-08T08:11:17Z

GPU/GPUTracking/Global/GPUChainTrackingClusterizer.cxx

    }

-    mRec->runParallelOuterLoop(doGPU, numLanes, [&](uint32_t lane) {
+    for (int32_t lane = 0; lane < numLanes; lane++) {


Just curious about this change here. When running with GPU, it should not make any difference. But when running on CPU backend, the new version would serialize while the old version would run in parallel.
Is this change intended?

Since this initialization step is cheap I consider that it makes no difference. However, I want to make sure that all network inits are done sequentially, just in case they make some mem-allocs which (might or might not) conflict. I saw some crashes when running online and this would remove a potential failure point.

alibuild · 2025-09-08T09:08:12Z

Error while checking build/O2/fullCI_slc9 for a545f08 at 2025-09-08 23:03:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1313: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_runCfClusterizer.hip.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1326: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_fillInputNNCPU.hip.o] Error 1
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1339: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_fillInputNNGPU.hip.o] Error 1
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1352: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_determineClass1Labels.hip.o] Error 1
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1365: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_determineClass2Labels.hip.o] Error 1
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
/sw/SOURCES/O2/14657-slc9_x86-64/0/GPU/GPUTracking/TPCClusterFinder/GPUTPCNNClusterizerKernels.h:32:1: error: class 'CfChargePos' was previously declared as a struct; this is valid, but may result in linker errors under the Microsoft C++ ABI [-Werror,-Wmismatched-tags]
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1378: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_publishClass1Regression.hip.o] Error 1
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1391: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_publishClass2Regression.hip.o] Error 1
make[2]: *** [GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/build.make:1404: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/__/__/__/include_gpu_onthefly/krnl_GPUTPCNNClusterizerKernels_publishDeconvolutionFlags.hip.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1175: GPU/GPUTracking/Base/hip/CMakeFiles/GPUTrackingHIPKernels.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:136: all] Error 2

Full log here.

alibuild · 2025-09-09T11:22:43Z

Error while checking build/O2/fullCI_slc9 for 7c47304 at 2025-09-09 14:01:

## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/374335e88f9e6cfa5b48586ec1fd55863d7540e0/slc9_x86-64/o2checkcode/1.0-local480/etc/modulefiles
++ cat
--

Full log here.

ChSonnabend · 2025-09-09T11:25:04Z

Build errors come from: [4893/5777] Building HIP object Detectors/ITSMFT/ITS/tracking/GPU/hip/CMakeFiles/O2lib-ITStrackingHIP.dir/TimeFrameGPU.hip.o
Seems unrelated(?)

Similar for MacOS (although there its the CCDBFetcher that failes)

davidrohr · 2025-09-09T11:27:02Z

@ktf @singiamtel : The FullCI fails here with:

========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
grep: error-log.txt: binary file matches
error: error: clang-tidy: Unknown command line argument '--load /sw/slc9_x86-64/o2codechecker/v20.1.7-local2/lib/libclangTidyAliceO2Module.so --extra-arg=--gcc-install-dir='.  Try: '/sw/slc9_x86-64/Clang/v20.1.7-1/bin-safe/clang-tidy --help'

So it seems the CodeChecker is broken?

Adding verbosity and fixing off-by-one error

4998576

ChSonnabend requested a review from davidrohr as a code owner September 5, 2025 18:45

alibuild mentioned this pull request Sep 5, 2025

Please consider the following formatting changes to #14657 ChSonnabend/AliceO2#35

Closed

removing unnecessary include, using GPUCommonLogger to fix CI build

5368d52

ChSonnabend marked this pull request as draft September 5, 2025 21:32

GetGrid spawns more threads than actual number -> Most probably expla…

d87f8fa

…ins out-of-bounds accesses and memory faults

alibuild mentioned this pull request Sep 6, 2025

Please consider the following formatting changes to #14657 ChSonnabend/AliceO2#36

Merged

ChSonnabend and others added 3 commits September 6, 2025 23:17

Fixing smem usage from CFClusterizer and adding rejection flag -> No …

d3f439e

…out-of-bounds in QC anymore

Adjusting kernels for GPU safe rejection

1bee99a

Please consider the following formatting changes

fe9b699

ChSonnabend marked this pull request as ready for review September 6, 2025 22:03

ChSonnabend requested a review from a team as a code owner September 6, 2025 22:03

Merge pull request #36 from alibuild/alibot-cleanup-14657

0ed462e

Please consider the following formatting changes to AliceO2Group#14657

ChSonnabend changed the title ~~NN clsuterizer: Adding verbosity and fixing off-by-one error~~ NN clsuterizer: Fixing memory access faults Sep 6, 2025

ChSonnabend enabled auto-merge (squash) September 6, 2025 22:27

ChSonnabend changed the title ~~NN clsuterizer: Fixing memory access faults~~ NN clusterizer: Fixing memory access faults Sep 6, 2025

Casting to avoid CI build failures

902ddc6

Changing formatter to not use std::

79cc38e

Remove usage of std::

b50afbb

Merge branch 'dev' into bug-fixes

1d02b30

davidrohr reviewed Sep 8, 2025

View reviewed changes

Adding back the runParallelOuterLoop

a545f08

Declaring CfChargePos as struct, not class

7c47304

davidrohr disabled auto-merge September 9, 2025 12:46

davidrohr merged commit cc7210c into AliceO2Group:dev Sep 9, 2025
10 of 11 checks passed

ChSonnabend deleted the bug-fixes branch September 11, 2025 22:37

NN clusterizer: Fixing memory access faults #14657

NN clusterizer: Fixing memory access faults #14657

Uh oh!

Conversation

ChSonnabend commented Sep 5, 2025

Uh oh!

github-actions bot commented Sep 5, 2025

Uh oh!

alibuild commented Sep 5, 2025

Uh oh!

alibuild commented Sep 5, 2025

Uh oh!

alibuild commented Sep 6, 2025

Uh oh!

alibuild commented Sep 7, 2025

Uh oh!

alibuild commented Sep 7, 2025

Uh oh!

alibuild commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChSonnabend commented Sep 8, 2025

Uh oh!

davidrohr Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

ChSonnabend Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

alibuild commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChSonnabend commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davidrohr commented Sep 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

alibuild commented Sep 7, 2025 •

edited

Loading

alibuild commented Sep 7, 2025 •

edited

Loading

alibuild commented Sep 8, 2025 •

edited

Loading

alibuild commented Sep 9, 2025 •

edited

Loading

ChSonnabend commented Sep 9, 2025 •

edited

Loading