Skip to content

Conversation

@sawenzel
Copy link
Collaborator

@sawenzel sawenzel commented Sep 9, 2025

…l level

We can now scale the material density beyond the module level. We simply need to use "MODULENAME/MATERIAL" strings in the configurable param.

Matching on individual material takes precedence over matching on the module level.

An example is

o2-sim --configKeyValues "SimMaterialParams.localDensityFactor=TPC/Air:1.2,TPC:2.0,ITS:5."

which will scale TPC air with a factor 1.2, the rest of TPC with factor 2.0 and all of ITS with factor 5.0

Fixes https://its.cern.ch/jira/browse/O2-6294

…l level

We can now scale the material density beyond the module level. We simply need
to use "MODULENAME/MATERIAL" strings in the configurable param.

Matching on individual material takes precedence over matching on the module level.

An example is
```
o2-sim --configKeyValues "SimMaterialParams.localDensityFactor=TPC/Air:1.2,TPC:2.0,ITS:5."
```
which will scale TPC air with a factor 1.2, the rest of TPC with factor 2.0 and
all of ITS with factor 5.0

Fixes https://its.cern.ch/jira/browse/O2-6294
@sawenzel sawenzel requested a review from shahor02 as a code owner September 9, 2025 15:01
@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@sawenzel
Copy link
Collaborator Author

sawenzel commented Sep 9, 2025

@alcaliva

@alibuild
Copy link
Collaborator

alibuild commented Sep 9, 2025

Error while checking build/O2/fullCI_slc9 for 08d5b55 at 2025-09-10 00:37:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
error: error: clang-tidy: Unknown command line argument '--load /sw/slc9_x86-64/o2codechecker/v20.1.7-local2/lib/libclangTidyAliceO2Module.so --extra-arg=--gcc-install-dir='.  Try: '/sw/slc9_x86-64/Clang/v20.1.7-1/bin-safe/clang-tidy --help'
error: error: clang-tidy: Unknown command line argument '--load /sw/slc9_x86-64/o2codechecker/v20.1.7-local2/lib/libclangTidyAliceO2Module.so --extra-arg=--gcc-install-dir='.  Try: '/sw/slc9_x86-64/Clang/v20.1.7-1/bin-safe/clang-tidy --help'
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@sawenzel sawenzel merged commit 91a7d8b into AliceO2Group:dev Sep 10, 2025
11 of 12 checks passed
@sawenzel sawenzel deleted the swenzel/O2-6294 branch September 10, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants