Skip to content

Conversation

@fmazzasc
Copy link
Contributor

BITS 0-6 were not set, in contrary to what was stated in the mcMask description in AnalysisDataModel.h .
I also added a bit to account for fake AB ITS tracklets (BIT 12) and fixed the description of the last three bits inAnalysisDataModel.h

Could you please have a look?
@shahor02 @jgrosseo @ddobrigk

@fmazzasc fmazzasc requested review from a team as code owners September 10, 2025 09:49
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

Copy link
Collaborator

@shahor02 shahor02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just 1 comment below.

}
if (trackIndex.includesDet(DetID::ITS)) {
auto itsGID = data.getITSContributorGID(trackIndex);
if (itsGID.isIndexSet()) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is not needed, if trackIndex.includesDet(DetID::ITS) is true, then the itsGID.isIndexSet() is guaranteed.
Just check

if (itsGID.getSource() == GIndex::ITS) { 
 ... as ITS track
} else {
 ... as AB track
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you ! Fixed

@alibuild
Copy link
Collaborator

alibuild commented Sep 10, 2025

Error while checking build/O2/fullCI_slc9 for 4ae732a at 2025-09-16 13:38:

No log files found

Full log here.

@f3sch
Copy link
Collaborator

f3sch commented Sep 25, 2025

Hi @shahor02, can we merge this if it looks good, thanks.

@shahor02 shahor02 merged commit c864689 into AliceO2Group:dev Sep 25, 2025
13 checks passed
plariono pushed a commit to plariono/AliceO2 that referenced this pull request Oct 23, 2025
* Add ITS fake clusters information to the mcMask

* remove redundant check

---------

Co-authored-by: Francesco Mazzaschi <fmazzasc@alipap1.cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants