Skip to content

TPC: Apply T/P scaling of VDrift only if T/P change is large enough #14668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wiechula merged 2 commits into from
Sep 25, 2025
Merged

TPC: Apply T/P scaling of VDrift only if T/P change is large enough #14668

wiechula merged 2 commits into from
Sep 25, 2025

Conversation

@matthias-kleiner
Copy link
Contributor

@matthias-kleiner matthias-kleiner commented Sep 11, 2025

  • suppress error for getting reference T/P in case default VDrift is used

@matthias-kleiner
TPC: Apply T/P scaling of VDrift only if T/P change is large enough
6c6d69f 
- suppress error for getting reference T/P in case default VDrift is used
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

matthias-kleiner
matthias-kleiner commented Sep 11, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Sep 11, 2025

Error while checking build/O2/fullCI_slc9 for 6c6d69f at 2025-09-11 10:24:

No log files found

Full log here.

wiechula
wiechula previously approved these changes Sep 11, 2025
View reviewed changes
shahor02
shahor02 reviewed Sep 11, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Sep 11, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for b4f5e43 at 2025-09-16 13:17:

No log files found

Full log here.

@wiechula wiechula enabled auto-merge (squash) September 11, 2025 10:59
@wiechula wiechula merged commit 6c5bbfb into AliceO2Group:dev Sep 25, 2025
14 checks passed
plariono pushed a commit to plariono/AliceO2 that referenced this pull request Oct 23, 2025
@matthias-kleiner @plariono
TPC: Apply T/P scaling of VDrift only if T/P change is large enough (A…
d16e1a3 
…liceO2Group#14668)

* TPC: Apply T/P scaling of VDrift only if T/P change is large enough

- suppress error for getting reference T/P in case default VDrift is used

* remove info message and print warning only once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahor02 shahor02 shahor02 approved these changes

@wiechula wiechula wiechula approved these changes

@davidrohr davidrohr Awaiting requested review from davidrohr davidrohr is a code owner

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matthias-kleiner @alibuild @shahor02 @wiechula