Skip to content

Conversation

@nicolaspoffley
Copy link
Contributor

Add protocol param to encode_websocket_handshake_reply which allows a response Sec-WebSocket-Accept in handshake. If no protocol is given to the function, Sec-WebSocket-Accept is not returned in the response.

@nicolaspoffley nicolaspoffley requested a review from a team as a code owner September 23, 2025 09:06
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@nicolaspoffley
Copy link
Contributor Author

@ktf

nicolaspoffley and others added 2 commits September 23, 2025 12:53
Co-authored-by: Giulio Eulisse <10544+ktf@users.noreply.github.com>
Please consider the following formatting changes to AliceO2Group#14687
@ktf ktf self-requested a review September 24, 2025 08:11
ktf
ktf previously approved these changes Sep 24, 2025
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 00c55fd at 2025-09-24 12:23:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14687-slc9_x86-64/0/Framework/Core/src/HTTPParser.cxx:226:27: error: 'protocol' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

@ktf ktf self-requested a review September 26, 2025 07:32
@ktf ktf merged commit 10dd8dc into AliceO2Group:dev Sep 27, 2025
11 checks passed
plariono pushed a commit to plariono/AliceO2 that referenced this pull request Oct 23, 2025
… which allows a response Sec-WebSocket-Accept in handshake. (AliceO2Group#14687)

DPL Websocket: Add overloaded encode_websocket_handshake_reply which allows a response Sec-WebSocket-Accept in handshake.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants