ITS3: use const view of ROFs, prepareROFData #14694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
f3sch
requested review from
arossi81,
fgrosa,
fprino,
mconcas and
shahor02
as code owners
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
fgrosa
approved these changes
Sep 26, 2025
mconcas
approved these changes
Sep 26, 2025
plariono
pushed a commit
to plariono/AliceO2
that referenced
this pull request
Oct 23, 2025
Signed-off-by: Felix Schlepper <felix.schlepper@cern.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new function, refactoring code already present for ITS2 into a new function
prepareROFData.Allowing it to be called for ITS3 as well without replicating.
Also, the code now explicitly takes a const view of the ROFs (more a cosmetic change).
Additionally, due to recent refactoring in the base code, this fixes ITS3 tracking (...again).