Skip to content

Improving signposts #14711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Oct 3, 2025
Merged

Improving signposts #14711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Framework/Core/src/CommonServices.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,30 +826,34 @@ auto flushMetrics(ServiceRegistryRef registry, DataProcessingStats& stats) -> vo
auto& relayer = registry.get<DataRelayer>();

// Send all the relevant metrics for the relayer to update the GUI
stats.flushChangedMetrics([&monitoring](DataProcessingStats::MetricSpec const& spec, int64_t timestamp, int64_t value) mutable -> void {
stats.flushChangedMetrics([&monitoring, sid](DataProcessingStats::MetricSpec const& spec, int64_t timestamp, int64_t value) mutable -> void {
// convert timestamp to a time_point
auto tp = std::chrono::time_point<std::chrono::system_clock, std::chrono::milliseconds>(std::chrono::milliseconds(timestamp));
auto metric = o2::monitoring::Metric{spec.name, Metric::DefaultVerbosity, tp};
if (spec.kind == DataProcessingStats::Kind::UInt64) {
if (value < 0) {
LOG(debug) << "Value for " << spec.name << " is negative, setting to 0";
O2_SIGNPOST_EVENT_EMIT(monitoring_service, sid, "flushChangedMetrics", "Value for %{public}s is negative, setting to 0",
spec.name.c_str());
value = 0;
}
metric.addValue((uint64_t)value, "value");
} else {
if (value > (int64_t)std::numeric_limits<int>::max()) {
LOG(warning) << "Value for " << spec.name << " is too large, setting to INT_MAX";
O2_SIGNPOST_EVENT_EMIT(monitoring_service, sid, "flushChangedMetrics", "Value for %{public}s is too large, setting to INT_MAX",
spec.name.c_str());
value = (int64_t)std::numeric_limits<int>::max();
}
if (value < (int64_t)std::numeric_limits<int>::min()) {
O2_SIGNPOST_EVENT_EMIT(monitoring_service, sid, "flushChangedMetrics", "Value for %{public}s is too small, setting to INT_MIN",
spec.name.c_str());
value = (int64_t)std::numeric_limits<int>::min();
LOG(warning) << "Value for " << spec.name << " is too small, setting to INT_MIN";
}
metric.addValue((int)value, "value");
}
if (spec.scope == DataProcessingStats::Scope::DPL) {
metric.addTag(o2::monitoring::tags::Key::Subsystem, o2::monitoring::tags::Value::DPL);
}
O2_SIGNPOST_EVENT_EMIT(monitoring_service, sid, "flushChangedMetrics", "Flushing metric %{public}s", spec.name.c_str());
monitoring.send(std::move(metric));
});
relayer.sendContextState();
Expand Down