-
Notifications
You must be signed in to change notification settings - Fork 483
Update of TPC fast space charge correction with splines #14723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
Error while checking build/O2/fullCI_slc9 for e820317 at 2025-10-07 11:17: Full log here. |
|
Error while checking build/O2/fullCI_slc9 for bacaa56 at 2025-10-15 16:15: Full log here. |
|
@sgorbuno : I fixed some of the compile issues. However, now the macros are failing, because the convUVto... functions were removed or changed. Could you have a look and fix them? |
|
Error while checking build/O2/fullCI_slc9 for 7e41329 at 2025-10-15 21:29: Full log here. |
22dbdec to
b92a15c
Compare
…osition of residuals
|
Error while checking build/O2/fullCI_slc9 for 1661fd6 at 2025-11-09 12:54: Full log here. |
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
The PR contains several commits:
non-uniform grid that corresponds to the track residual voxels
fixed propagation of the track residual data to the TPC row edges
limits for SC correction values per TPC row
fast merge of several corrections
multithreaded reading of the residual tree
fixed initialization of the track residuals in the test macro
minimised number of coordinate transformations - everything is calculated in the local XYZ coordinates
backward compatibility tested. When the old object is read with the new code, it behaves identically inside the spline grid. Outside the grid, new splines can behave differently because of the new propagation to the row edges.