Skip to content

GPU: Wshadow compiler directive not needed in HIP Includes System #14738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 2 commits into from
Oct 15, 2025
Merged

GPU: Wshadow compiler directive not needed in HIP Includes System #14738

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e53b84
TODO: Wshadow compiler directive not needed
vikasssinghal Oct 14, 2025
ada4e3f
Removed all three lines push, pragma diagnostic, pop
vikasssinghal Oct 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
#include <hip/hip_ext.h>
#include <hipcub/hipcub.hpp>
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wshadow" // FIXME: Is this still needed?
// #pragma GCC diagnostic ignored "-Wshadow" // VS: This compiler directive for -Wshadow is not needed.

Check failure on line 26 in GPU/GPUTracking/Base/hip/GPUReconstructionHIPIncludesSystem.h

View workflow job for this annotation

GitHub Actions / PR formatting / whitespace

Trailing spaces 

Remove the trailing spaces at the end of the line.
Copy link
Collaborator

@davidrohr davidrohr Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove the pragma diagnostic ignored, please also remove the related pragma diagnostic push and pop. And you can also please remove the lines, not just comment them. Finally, if you work in the GPU code, please prepend the PR title with a "GPU:"

Copy link
Contributor Author

@vikasssinghal vikasssinghal Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David,
I'll remove all three lines (push, pragma diagnostic, pop) and commit again.
Changed the PR name from TODO to GPU.

#include <thrust/sort.h>
#include <thrust/execution_policy.h>
#include <thrust/device_ptr.h>
Expand Down
Loading