Skip to content

Conversation

@amorsch
Copy link
Collaborator

@amorsch amorsch commented Oct 16, 2025

Corrected positions of volumes in caveRB24 after recent updates to accommodate FOCAL in the barrel volume.
Since the mother volume has been shortened by 150 cm in the z-direction, the volumes have to be moved 75 cm closer to the center. This concerns ZEM , Compensator magnet and FDD (A-side).

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@andreasmolander
Copy link
Collaborator

For other reviewers, there's a little gear icon above the file diffs, with which you can hide whitespaces (the mentioned clang changes). @sahilupadhyaya92, could you run your simulation studies again with this branch to cross-check the location of FDD? Sometimes with the geometries, it's difficult to be sure what will happen just by checking the code.

@sawenzel
Copy link
Collaborator

sawenzel commented Oct 16, 2025

@amorsch : This PR had considerable whitespace changes. Would it be possible to make a version with just the necessary bug-fix changes? (I am puzzled why clang format applies global formatting changes. We typically only make sure that each new diff is well formatted in order to stay as local with the code changes as possible: (git clang-format HEAD^).

@amorsch
Copy link
Collaborator Author

amorsch commented Oct 16, 2025

@sawenzel Ok I will remove the style changes. I thought it will in this case not pass the corresponding checks.
@andreasmolander Displaying the geometry with root I see the FDD now centered at z = 1695 cm

@shahor02
Copy link
Collaborator

@amorsch does this PR modify the geometry/materials in the acceptance range (i.e. do we need to regenerate CCDB geometries and material LUT)?

@amorsch
Copy link
Collaborator Author

amorsch commented Oct 16, 2025

@amorsch does this PR modify the geometry/materials in the acceptance range (i.e. do we need to regenerate CCDB geometries and material LUT)?

@shahor02 No, only elements in the very forward direction have been moved.

@amorsch amorsch force-pushed the RB24positioningFix branch from 7a72dc5 to 90593ea Compare October 16, 2025 18:47
@sahilupadhyaya92
Copy link
Collaborator

@andreasmolander @amorsch
I have checked and everything looks ok.

@andreasmolander
Copy link
Collaborator

FIT code changes OK by me (@sahilupadhyaya92 also cross-checked the location). Not sure if I have a say regarding the other changes so I maybe leave final PR approval to @sawenzel or @shahor02

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 90593ea at 2025-10-18 15:53:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
[0 more errors; see full log]

Full log here.

@sawenzel sawenzel merged commit eaeee05 into AliceO2Group:dev Oct 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

6 participants