-
Notifications
You must be signed in to change notification settings - Fork 483
corrected positions of volumes in RB24 after recent Cave updates #14746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
For other reviewers, there's a little gear icon above the file diffs, with which you can hide whitespaces (the mentioned clang changes). @sahilupadhyaya92, could you run your simulation studies again with this branch to cross-check the location of FDD? Sometimes with the geometries, it's difficult to be sure what will happen just by checking the code. |
|
@amorsch : This PR had considerable whitespace changes. Would it be possible to make a version with just the necessary bug-fix changes? (I am puzzled why clang format applies global formatting changes. We typically only make sure that each new diff is well formatted in order to stay as local with the code changes as possible: ( |
|
@sawenzel Ok I will remove the style changes. I thought it will in this case not pass the corresponding checks. |
|
@amorsch does this PR modify the geometry/materials in the acceptance range (i.e. do we need to regenerate CCDB geometries and material LUT)? |
7a72dc5 to
90593ea
Compare
|
@andreasmolander @amorsch |
|
FIT code changes OK by me (@sahilupadhyaya92 also cross-checked the location). Not sure if I have a say regarding the other changes so I maybe leave final PR approval to @sawenzel or @shahor02 |
|
Error while checking build/O2/fullCI_slc9 for 90593ea at 2025-10-18 15:53: Full log here. |
Corrected positions of volumes in caveRB24 after recent updates to accommodate FOCAL in the barrel volume.
Since the mother volume has been shortened by 150 cm in the z-direction, the volumes have to be moved 75 cm closer to the center. This concerns ZEM , Compensator magnet and FDD (A-side).