Redefing BasicXYZVHit::mDetectorID from short to ushort #14760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahor02
requested review from
arossi81,
f3sch,
fgrosa,
fprino,
mconcas and
sawenzel
as code owners
Contributor
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
f3sch
approved these changes
Oct 22, 2025
sawenzel
approved these changes
Oct 23, 2025
Collaborator
sawenzel
left a comment
sawenzel
left a comment
There was a problem hiding this comment.
Fine for me. Nobody seems to have used negative numbers for mDetectorID, so the change should be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow for up to 0xffff sensors per detector in Alice3