[Fix] Correct Reporting of CTF Compressed Payload in Metadata #14761
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reporting of the CTF compressed payload size by the
Metadataclass is wrong.Metadata stores the sizes of the encoded data, dictionaries, and the size of incompressible symbols in multiples of the word size of the underlying storage buffer. To get to bytes, the member function
Metadata::getCompressedSize()multipliesDictWords + nDataWords + nLiteralWordsbystreamSize.streamSizeon most occasions will not match the word size of the storage buffer, resulting in wrong reporting of the byte size for the compressed payload.This fix:
Metadata::getCompressedSize()Metadataclass