Skip to content

additional features added to TRK geometry #14772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mconcas merged 4 commits into from
Nov 3, 2025
Merged

additional features added to TRK geometry #14772

mconcas merged 4 commits into from
Nov 3, 2025

Conversation

@AizatDaribayeva
Copy link
Contributor

@AizatDaribayeva AizatDaribayeva commented Oct 27, 2025

Additional features regarding T2L coordinate transformations added for flat sensors, a.k.a for ML & OT. For VD, the geometry itself should be more refined. For ML & OT, further finer segmentations are foreseen, and these features will be transparent to them.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 27, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild alibuild mentioned this pull request Oct 27, 2025
Closed
njacazio
njacazio previously approved these changes Oct 28, 2025
View reviewed changes
@alibuild
Copy link
Collaborator

alibuild commented Oct 28, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for c74725f at 2025-10-30 06:19:

## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:57:47: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:60:49: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:62:49: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:64:45: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:66:42: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:68:50: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:70:56: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:86:47: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:89:45: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:105:37: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:114:14: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:120:37: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:135:122: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:165:11: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/14772-slc9_x86-64/0/Detectors/Upgrades/ALICE3/TRK/simulation/src/VDGeometryBuilder.cxx:260:37: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

@mconcas
Copy link
Collaborator

mconcas commented Oct 30, 2025

#14778 should fix the codechecker

@mconcas
Copy link
Collaborator

mconcas commented Oct 31, 2025

@AizatDaribayeva recent merges created some conflicts, could you please resolve them and update this PR?

@AizatDaribayeva
Copy link
Contributor Author

AizatDaribayeva commented Oct 31, 2025

@AizatDaribayeva recent merges created some conflicts, could you please resolve them and update this PR?

@mconcas done.

@alibuild
Copy link
Collaborator

alibuild commented Nov 1, 2025 •
edited
Loading

Error while checking build/O2/fullCI_slc9 for b7f3584 at 2025-11-02 01:24:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
[0 more errors; see full log]

Full log here.

@mconcas mconcas merged commit 80787ec into AliceO2Group:dev Nov 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mconcas mconcas mconcas approved these changes

@njacazio njacazio njacazio left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@AizatDaribayeva @alibuild @mconcas @njacazio