Skip to content

Conversation

@aferrero2707
Copy link
Collaborator

Two new environment variables are introduced to provide the fraction of rejected MCH events separately for the cases where the selection based on ITS IRframes is either enabled (CUT_RANDOM_FRACTION_MCH_WITH_ITS) or disabled (CUT_RANDOM_FRACTION_MCH_NO_ITS).

The selection based on ITS is enabled by default in SYNC processing for physics runs where ITS is included in the data taking. It can be however explicitely disabled by adding MCH_DISABLE_ITS_IRFRAMES_SELECTION=1 to the custom environment variables. In this case, CUT_RANDOM_FRACTION_MCH_NO_ITS is used.

The CUT_RANDOM_FRACTION_MCH variable, as well as the two new ones, can still be overridden by setting them explicitly in the shell environment. Moreover, the ITS selection is applied whenever MCH_DISABLE_ITS_IRFRAMES_SELECTION is undefined, therefore the changes are fully backward compatible.

Two new environment variables are introduced to provide the fraction of
rejected MCH events separately for the cases where the selection based
on ITS IRframes is either enabled (CUT_RANDOM_FRACTION_MCH_WITH_ITS) or
disabled (CUT_RANDOM_FRACTION_MCH_NO_ITS).

The selection based on ITS is enabled by default in SYNC processing for
physics runs where ITS is included in the data taking. It can be however
explicitely disabled by adding MCH_DISABLE_ITS_IRFRAMES_SELECTION=1 to
the custom environment variables. In this case, CUT_RANDOM_FRACTION_MCH_NO_ITS
is used.

The CUT_RANDOM_FRACTION_MCH variable, as well as the two new ones, can still
be overridden by setting them explicitly in the shell environment.
Moreover, the ITS selection is applied whenever MCH_DISABLE_ITS_IRFRAMES_SELECTION
is undefined, therefore the changes are fully backward compatible.
@aferrero2707 aferrero2707 requested a review from a team as a code owner October 28, 2025 08:52
@aferrero2707 aferrero2707 changed the title [MCH add cut random fraction setting for the cases with and without ITS MCH add cut random fraction setting for the cases with and without ITS Oct 28, 2025
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@aferrero2707
Copy link
Collaborator Author

@davidrohr @ehellbar this is an update for PR #14028 (which I did not realize was closed without merging), addressing your comments and also adding an optional variable for explicitly disabling the ITS selection in physics runs.
I have tested locally all possible combinations of the variables, and checked that indeed the expected workflow options are set.

In particular, the explicit disabling will be needed to investigate the beam background in the first part of the Pb-Pb run this year, since the background effects are usually suppressed in SYNC when requiring ITS vertices.

We would therefore need to deploy it to P2 before the start of the Pb-Pb run, ideally this week. This was already discussed and agreed with RC.

Thanks a lot in advance!

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 7cd2a0c at 2025-10-28 13:51:

## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
[0 more errors; see full log]

Full log here.

@aferrero2707
Copy link
Collaborator Author

@ehellbar the CI is green, can we proceed with the merging, or is there something else to check/modify? Thanks!

@ehellbar ehellbar merged commit b79e289 into AliceO2Group:dev Oct 29, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants