Skip to content

GPU QA: Fix colors when writing histograms to ROOT files #14796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 2 commits into from
Nov 7, 2025
Merged

GPU QA: Fix colors when writing histograms to ROOT files #14796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e77ed3d
GPU QA: Fix colors when writing histograms to ROOT files
davidrohr Nov 5, 2025
b434fd7
GPU: Remove dead code
davidrohr Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions GPU/GPUTracking/Merger/GPUTPCGMTrackParam.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,6 @@

#define GPUCA_CADEBUG 0
#define DEBUG_SINGLE_TRACK -1
#define EXTRACT_RESIDUALS 0

#if EXTRACT_RESIDUALS == 1
#include "GPUROOTDump.h"
#endif

#include "GPUTPCDef.h"
#include "GPUTPCGMTrackParam.h"
Expand Down
6 changes: 3 additions & 3 deletions GPU/GPUTracking/qa/GPUQA.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2027,11 +2027,11 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
}

std::vector<Color_t> colorNums(COLORCOUNT);
if (!qcout) {
if (!(qcout || mConfig.writeRootFiles)) {
[[maybe_unused]] static int32_t initColorsInitialized = initColors();
}
for (int32_t i = 0; i < COLORCOUNT; i++) {
colorNums[i] = qcout ? defaultColorNums[i] : mColors[i]->GetNumber();
colorNums[i] = (qcout || mConfig.writeRootFiles) ? defaultColorNums[i] : mColors[i]->GetNumber();
}

bool mcAvail = mcPresent();
Expand Down Expand Up @@ -2288,7 +2288,7 @@ int32_t GPUQA::DrawQAHistograms(TObjArray* qcout)
continue;
}
e->SetMarkerColor(kBlack);
e->SetLineColor(colorNums[(l == 2 ? (ConfigNumInputs * 2 + k) : (k * 2 + l)) % COLORCOUNT]);
e->SetLineColor(colorNums[(k * 3 + l) % COLORCOUNT]);
e->GetHistogram()->GetYaxis()->SetRangeUser(-0.02, 1.02);
e->Draw(k || l ? "same P" : "AP");
if (j == 0) {
Expand Down