Skip to content

DPL: fix thread safety of slot allocation in runtime_error_f #14835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ktf merged 1 commit into from
Nov 20, 2025
Merged

DPL: fix thread safety of slot allocation in runtime_error_f #14835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions Framework/Foundation/src/RuntimeError.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,11 @@ RuntimeError& error_from_ref(RuntimeErrorRef ref)
RuntimeErrorRef runtime_error_f(const char* format, ...)
{
int i = 0;
bool expected = false;
while (gErrorBooking[i].compare_exchange_strong(expected, true) == false) {
while (true) {
bool expected = false;
if (gErrorBooking[i].compare_exchange_strong(expected, true) == true) {
break;
}
++i;
if (i >= RuntimeError::MAX_RUNTIME_ERRORS) {
throw std::runtime_error("Too many o2::framework::runtime_error thrown without proper cleanup.");
Expand All @@ -78,11 +81,18 @@ RuntimeErrorRef runtime_error_f(const char* format, ...)
RuntimeErrorRef runtime_error(const char* s)
{
int i = 0;
bool expected = false;
while (gErrorBooking[i].compare_exchange_strong(expected, true) == false) {
while (true) {
bool expected = false;
if (gErrorBooking[i].compare_exchange_strong(expected, true) == true) {
break;
}
++i;
if (i >= RuntimeError::MAX_RUNTIME_ERRORS) {
throw std::runtime_error("Too many o2::framework::runtime_error thrown without proper cleanup.");
}
}
strncpy(gError[i].what, s, RuntimeError::MAX_RUNTIME_ERROR_SIZE);
strncpy(gError[i].what, s, RuntimeError::MAX_RUNTIME_ERROR_SIZE - 1);
gError[i].what[RuntimeError::MAX_RUNTIME_ERROR_SIZE - 1] = 0;
gError[i].maxBacktrace = canDumpBacktrace() ? backtrace(gError[i].backtrace, BacktraceHelpers::MAX_BACKTRACE_SIZE) : 0;
return RuntimeErrorRef{i};
}
Expand Down