Skip to content

Generalize path/file finding for external collision context #14867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sawenzel merged 1 commit into from
Nov 29, 2025
Merged

Generalize path/file finding for external collision context #14867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Steer/src/CollisionContextTool.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,8 +260,15 @@ bool copy_collision_context(const std::string& external_path, int this_tf_id, in
{
namespace fs = std::filesystem;
try {
// Construct source file path
fs::path filename = fs::path(external_path) / ("collission_context_" + std::to_string(this_tf_id) + ".root");
fs::path filename;
if (fs::exists(external_path) && fs::is_regular_file(external_path)) {
Copy link
Member

@ktf ktf Nov 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would exclude symlinks. Is that expected?

Copy link
Collaborator Author

@sawenzel sawenzel Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good enough for now.

std::cout << "external_path is an existing file: " << external_path << "\n";
// use it directly
filename = fs::path(external_path);
} else {
// Construct source file path
filename = fs::path(external_path) / ("collission_context_" + std::to_string(this_tf_id) + ".root");
}

LOG(info) << "Checking existence of file: " << filename;

Expand Down