Skip to content

Conversation

@aalkin
Copy link
Member

@aalkin aalkin commented Dec 10, 2025

Replace for loops with ranges manipulation where appropriate in workflow construction code

@aalkin aalkin requested a review from a team as a code owner December 10, 2025 09:46
@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@alibuild
Copy link
Collaborator

alibuild commented Dec 10, 2025

Error while checking build/O2/fullCI_slc9 for a68da09 at 2025-12-13 00:07:

## sw/BUILD/O2-full-system-test-latest/log
command o2-sim-digitizer-workflow -n 5 --simPrefixQED qed/o2sim --qed-x-section-ratio 4477.35 --disable-mc --sims o2sim --tpc-lanes 32 --shm-segment-size 8000000000 -b --skipDet TRD --configKeyValues "HBFUtils.nHBFPerTF=128;HBFUtils.orbitFirst=0;HBFUtils.orbitFirstSampled=0;HBFUtils.obligatorySOR=false;HBFUtils.runNumber=310000;;HBFUtils.maxNOrbits=128;" --interactionRate 50000 --early-forward-policy always had nonzero exit code 128
[ERROR] Workflow crashed - PID 3294 (PHOSDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3265 (MIDDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3149 (ZDCDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3207 (ITSDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3178 (CPVDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3555 (TPCDigitizer_18) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3410 (TPCDigitizer_13) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 4106 (TPCDigitizer_9) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3236 (MFTDigitizer) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 4048 (TPCDigitizer_7) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3381 (TPCDigitizer_12) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3729 (TPCDigitizer_24) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3526 (TPCDigitizer_17) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3758 (TPCDigitizer_25) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 2975 (TPCDigitizer_0) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3700 (TPCDigitizer_23) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3439 (TPCDigitizer_14) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3497 (TPCDigitizer_16) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3845 (TPCDigitizer_28) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 4019 (TPCDigitizer_6) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3004 (TPCDigitizer_1) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3990 (TPCDigitizer_5) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 4077 (TPCDigitizer_8) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3874 (TPCDigitizer_29) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3352 (TPCDigitizer_11) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3323 (TPCDigitizer_10) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3584 (TPCDigitizer_19) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3613 (TPCDigitizer_20) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3062 (TPCDigitizer_3) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3642 (TPCDigitizer_21) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3033 (TPCDigitizer_2) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3816 (TPCDigitizer_27) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3903 (TPCDigitizer_30) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3932 (TPCDigitizer_31) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3961 (TPCDigitizer_4) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3468 (TPCDigitizer_15) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3787 (TPCDigitizer_26) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR] Workflow crashed - PID 3671 (TPCDigitizer_22) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device TPCDigitizer_0: pid 2975 (exit 128)
[ERROR]  - Device TPCDigitizer_1: pid 3004 (exit 128)
[ERROR]  - Device TPCDigitizer_2: pid 3033 (exit 128)
[ERROR]  - Device TPCDigitizer_3: pid 3062 (exit 128)
[ERROR]  - Device ZDCDigitizer: pid 3149 (exit 128)
[ERROR]  - Device CPVDigitizer: pid 3178 (exit 128)
[ERROR]  - Device ITSDigitizer: pid 3207 (exit 128)
[ERROR]  - Device MFTDigitizer: pid 3236 (exit 128)
[ERROR]  - Device MIDDigitizer: pid 3265 (exit 128)
[0 more errors; see full log]

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI_slc9 for 9394914 at 2025-12-13 08:08:

## sw/BUILD/O2-latest/log
/sw/SOURCES/O2/14907-slc9_x86-64/0/Framework/Core/src/AnalysisSupportHelpers.cxx:131:42: error: 'struct o2::framework::DataProcessorSpec' has no member named 'outpus'; did you mean 'outputs'?
ninja: build stopped: subcommand failed.

Full log here.

@aalkin aalkin marked this pull request as draft December 13, 2025 07:36
@aalkin aalkin marked this pull request as ready for review December 13, 2025 12:24
@aalkin aalkin requested a review from ktf December 13, 2025 17:00
@ktf ktf merged commit 70b1040 into AliceO2Group:dev Dec 16, 2025
11 checks passed
@ktf
Copy link
Member

ktf commented Dec 16, 2025

Works on hyperloop, fullCI is also ok, halves the affected code. Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants