Skip to content

TRD: updates in vdrift and ExB calibration + possibility to use slope in chi2 matching#14989

Open
glegras wants to merge 6 commits intoAliceO2Group:devfrom
glegras:trdtracking
Open

TRD: updates in vdrift and ExB calibration + possibility to use slope in chi2 matching#14989
glegras wants to merge 6 commits intoAliceO2Group:devfrom
glegras:trdtracking

Conversation

@glegras
Copy link
Contributor

@glegras glegras commented Jan 23, 2026

No description provided.

@github-actions
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

@glegras glegras marked this pull request as ready for review February 9, 2026 17:34
@glegras glegras requested review from a team, bazinski, davidrohr, f3sch and wille10 as code owners February 9, 2026 17:34
return constants::MPVDEDXDEFAULT;
}
averageGain /= ngood;
return averageGain;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should not the averages be precalculated at initialisation and assigned to a non-persistent data member?

mAngleToDyA = -0.1f;
mAngleToDyB = 1.89f;
mAngleToDyC = -0.4f;
mDyB = 0.035f;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not the mRPhiB and mDyB be ideally the same? At least, how they can have opposite signs??

@alibuild
Copy link
Collaborator

alibuild commented Feb 9, 2026

Error while checking build/O2/fullCI_slc9 for 3c5ceb0 at 2026-02-09 19:46:

## sw/BUILD/O2-latest/log
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants