Skip to content

[O2B-536] Clean selection model #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
martinboulais wants to merge 5 commits into
base: main
Choose a base branch
from

Clean selection model

e9407a6
Select commit
Loading
Failed to load commit list.
Draft

[O2B-536] Clean selection model #1835

Clean selection model
e9407a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Feb 14, 2025 in 1s

0.00% of diff hit (target 44.57%)

View this Pull Request on Codecov

0.00% of diff hit (target 44.57%)

Annotations

Check warning on line 22 in lib/public/components/Filters/RunsFilter/runDefinitionFilter.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/Filters/RunsFilter/runDefinitionFilter.js#L22 

Added line #L22 was not covered by tests

Check warning on line 81 in lib/public/components/Filters/common/FilterModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/Filters/common/FilterModel.js#L81 

Added line #L81 was not covered by tests

Check warning on line 43 in lib/public/components/Filters/common/filters/NumericalComparisonFilterModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/Filters/common/filters/NumericalComparisonFilterModel.js#L43 

Added line #L43 was not covered by tests

Check warning on line 46 in lib/public/components/Filters/common/filters/NumericalComparisonFilterModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/Filters/common/filters/NumericalComparisonFilterModel.js#L45-L46 

Added lines #L45 - L46 were not covered by tests

Check warning on line 51 in lib/public/components/Filters/common/filters/checkboxFilter.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/Filters/common/filters/checkboxFilter.js#L51 

Added line #L51 was not covered by tests

Check warning on line 31 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L29-L31 

Added lines #L29 - L31 were not covered by tests

Check warning on line 35 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L33-L35 

Added lines #L33 - L35 were not covered by tests

Check warning on line 43 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L43 

Added line #L43 was not covered by tests

Check warning on line 45 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L45 

Added line #L45 was not covered by tests

Check warning on line 48 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L47-L48 

Added lines #L47 - L48 were not covered by tests

Check warning on line 57 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L56-L57 

Added lines #L56 - L57 were not covered by tests

Check warning on line 68 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L65-L68 

Added lines #L65 - L68 were not covered by tests

Check warning on line 72 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L72 

Added line #L72 was not covered by tests

Check warning on line 83 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L80-L83 

Added lines #L80 - L83 were not covered by tests

Check warning on line 93 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L92-L93 

Added lines #L92 - L93 were not covered by tests

Check warning on line 103 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L101-L103 

Added lines #L101 - L103 were not covered by tests

Check warning on line 115 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L112-L115 

Added lines #L112 - L115 were not covered by tests

Check warning on line 119 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L117-L119 

Added lines #L117 - L119 were not covered by tests

Check warning on line 126 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L125-L126 

Added lines #L125 - L126 were not covered by tests

Check warning on line 129 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L128-L129 

Added lines #L128 - L129 were not covered by tests

Check warning on line 132 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L131-L132 

Added lines #L131 - L132 were not covered by tests

Check warning on line 135 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L134-L135 

Added lines #L134 - L135 were not covered by tests

Check warning on line 139 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L139 

Added line #L139 was not covered by tests

Check warning on line 150 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L147-L150 

Added lines #L147 - L150 were not covered by tests

Check warning on line 160 in lib/public/components/common/selection/FilterableRemoteSelectionModel.js

See this annotation in the file changed.

@codecov codecov / codecov/patch

lib/public/components/common/selection/FilterableRemoteSelectionModel.js#L157-L160 

Added lines #L157 - L160 were not covered by tests
View more details on Codecov