-
Notifications
You must be signed in to change notification settings - Fork 21
[O2B-1503] LHCFills page, fill-number filter added #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2033 +/- ##
==========================================
+ Coverage 45.35% 45.59% +0.24%
==========================================
Files 1026 1028 +2
Lines 17113 17136 +23
Branches 3111 3120 +9
==========================================
+ Hits 7762 7814 +52
+ Misses 9351 9322 -29 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Waiting for pr2030 |
56e5c6a to
847d092
Compare
This reverts commit 695622b.
…ith the query/reset logic. Just set the value afterwards
847d092 to
3110c29
Compare
3110c29 to
d6c7ec3
Compare
graduta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on dealing with both front-end and back-end changes. I left a few comments
lib/public/components/Filters/LhcFillsFilter/fillNumberFilter.js
Outdated
Show resolved
Hide resolved
d6c7ec3 to
ecfa3d9
Compare
…. Feedback processed.
768e86f to
1e3f503
Compare
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: