Skip to content

Conversation

@Houwie7000
Copy link
Collaborator

@Houwie7000 Houwie7000 commented Dec 1, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • LHCFills page now has a 'fill number filter option'

Notable changes for developers:

  • validateRange moved out of RunFilterDTO to utilities to reuse in other DTO's

Changes made to the database:

@Houwie7000 Houwie7000 requested a review from isaachilly December 1, 2025 15:40
@Houwie7000 Houwie7000 self-assigned this Dec 1, 2025
@Houwie7000 Houwie7000 added frontend backend javascript Pull requests that update Javascript code labels Dec 1, 2025
@Houwie7000 Houwie7000 marked this pull request as ready for review December 1, 2025 15:41
@Houwie7000 Houwie7000 requested a review from graduta as a code owner December 1, 2025 15:41
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 96.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.59%. Comparing base (5081ae9) to head (e5bbc05).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ponents/Filters/LhcFillsFilter/fillNumberFilter.js 0.00% 1 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2033      +/-   ##
==========================================
+ Coverage   45.35%   45.59%   +0.24%     
==========================================
  Files        1026     1028       +2     
  Lines       17113    17136      +23     
  Branches     3111     3120       +9     
==========================================
+ Hits         7762     7814      +52     
+ Misses       9351     9322      -29     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Houwie7000
Copy link
Collaborator Author

Waiting for pr2030

@Houwie7000 Houwie7000 force-pushed the feature/O2B-1503/lhcfills-fill-numbers-filter branch from 56e5c6a to 847d092 Compare December 8, 2025 13:10
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1503/lhcfills-fill-numbers-filter branch from 847d092 to 3110c29 Compare December 11, 2025 11:12
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1503/lhcfills-fill-numbers-filter branch from 3110c29 to d6c7ec3 Compare December 11, 2025 16:17
Copy link
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on dealing with both front-end and back-end changes. I left a few comments

@Houwie7000 Houwie7000 force-pushed the feature/O2B-1503/lhcfills-fill-numbers-filter branch from d6c7ec3 to ecfa3d9 Compare December 15, 2025 09:21
@Houwie7000 Houwie7000 requested a review from graduta December 15, 2025 11:20
Base automatically changed from feature/O2B-1502/filtering-panel-lhc-fills-frontend to main December 15, 2025 13:24
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1503/lhcfills-fill-numbers-filter branch from 768e86f to 1e3f503 Compare December 15, 2025 15:55
@Houwie7000 Houwie7000 requested a review from graduta December 18, 2025 12:26
@graduta graduta merged commit 4d0e2a0 into main Dec 18, 2025
24 checks passed
@graduta graduta deleted the feature/O2B-1503/lhcfills-fill-numbers-filter branch December 18, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

3 participants