[O2B-1509] LHCfills scheme name filter #2046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaachilly
reviewed
Jan 25, 2026
lib/public/components/Filters/LhcFillsFilter/schemeNameFilter.js
Outdated
Show resolved
Hide resolved
Renamed occurrences of 'schemename' to 'scheme name' in test descriptions and variable names for consistency.
Removed 'scheme-name-filter' class from the scheme name filter component and updated test selectors to use '.fillingSchemeName-filter input' instead so as not to use a class as essentially an ID.
isaachilly
previously approved these changes
Jan 25, 2026
…be under LHCFills Removed the dedicated beamsTypes controller, router, DTO, and use case. Moved the beam types endpoint under the lhcFills controller and router, and implemented the service logic in lib/server/services/beam/getAllBeamTypes.js. Updated frontend provider and imports to use the new endpoint and naming (beamTypes instead of beamsTypes).
Change was needed for runDuration filter but then this was modified in a way that voids this.
Replaces SelectionModel with SelectionFilterModel for improved filter handling.
…com:AliceO2Group/Bookkeeping into feature/O2B-1508/lhcfills-beam-types-filter
These changes reduce unnecessary conversions and eliminate dead code/comments to avoid potential issues and improve code clarity.
Expand and tighten tests around the beamType filter across API, use-case, and public UI tests.
…model Removed the redundant `model` argument to align with lhcfills model API.
…re/O2B-1509/lhcfills-scheme-name-filter
Clean up code.
Enforce a 64-character maximum to match database field type.
Base automatically changed from
feature/O2B-1508/lhcfills-beam-types-filter
to
main
February 9, 2026 18:38
…re/O2B-1509/lhcfills-scheme-name-filter
graduta
previously approved these changes
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: