[O2B-1528] Split GAQ summary requests by isaachilly · Pull Request #2071 · AliceO2Group/Bookkeeping

isaachilly · 2026-02-03T08:42:38Z

I have a JIRA ticket

branch and/or PR name(s) include(s) JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected

Notable changes for users:

GAQ Summary re-enabled with sequential loading of each summary in the table

Notable changes for developers:

N/A

Changes made to the database:

N/A

Replace misspelled parameter `verifiedd_flags_list` with the correct `verified_flags_list` in QcFlagRepository.

Remove incorrect/duplicated identifier `verifiedd_flags_list` from the destructuring and mapping in QcFlagRepository.

Add optional runNumber filtering for GAQ summaries. Controller validation and handler accept runNumber query param and pass it to GaqService; GaqService forwards runNumber to QcFlagRepository and unwraps a single-run summary when requested. RunsPerDataPassOverviewModel tracks per-run RemoteData in _gaqSummary$, fetches GAQ summaries for visible runs, and RunsPerDataPassOverviewPage renders loading/success/failure states. These changes enable fetching and displaying GAQ data scoped to individual runs to reduce load and improve UX.

Make GAQ summary fetches run sequentially so to ease reduce load on the database.

…se load Make runNumber a required Joi parameter to prevent user stressing the database fetching data for all runs of a dataPass. Intended to be reverted once database query has been optimised.

Tighten Joi validation for GAQ summary by requiring dataPassId and runNumber to be positive numbers.

Adjust the runsPerDataPass overview test to match updated row and expected GAQ values.

Update qcFlags GAQ summary tests to include runNumber and strengthen request validation coverage.

codecov · 2026-02-03T08:45:21Z

Codecov Report

❌ Patch coverage is 19.67213% with 49 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.62%. Comparing base (aeea2c4) to head (e6e6388).

Files with missing lines	Patch %	Lines
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js	0.00%	36 Missing ⚠️
...Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js	0.00%	13 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2071      +/-   ##
==========================================
+ Coverage   45.55%   45.62%   +0.06%     
==========================================
  Files        1031     1031              
  Lines       17196    17249      +53     
  Branches     3129     3136       +7     
==========================================
+ Hits         7834     7870      +36     
- Misses       9362     9379      +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Use RemoteDataSource and AbortController to make per-run GAQ summary fetches cancelable. Can be easily adapted to use an array of remotedatasources if in the future we decide to request them in parallel.

When updating the GAQ summary for a run, store the actual success payload instead of the raw remoteData object.

Add a test that captures outgoing GAQ summary requests and asserts each run triggers exactly one GAQ request.

NarrowsProjects · 2026-02-09T10:09:25Z

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js

+                    try {
+                        await this._fetchGaqSummary(runNumber);
+                    } catch {
+                        if (signal.aborted) {


I'm not sure if this last check is needed. Additionally, you might want to print some kind of warning about the run number that was aborted

Correct. remoteDataSource will handle any errors internally without re-throwing so we can remove this try/catch.

Regarding printing a warning, the requests will only be aborted when a user does something to remove the table, I.E change page, change pagination etc. I think in these situations the user does not need to know the past data was aborted.

NarrowsProjects · 2026-02-09T10:44:22Z

lib/server/services/qualityControlFlag/GaqService.js

     * @return {Promise<GaqSummary>} Resolves with the GAQ Summary
     */
-    async getSummary(dataPassId, { mcReproducibleAsNotBad = false } = {}) {
+    async getSummary(dataPassId, { mcReproducibleAsNotBad = false, runNumber } = {}) {


dataPassId is not documented

Could you elaborate? If you mean in terms of the JSDoc then it is there, at the top.

NarrowsProjects · 2026-02-09T10:47:17Z

lib/server/services/qualityControlFlag/GaqService.js

     * @return {Promise<GaqSummary>} Resolves with the GAQ Summary
     */
-    async getSummary(dataPassId, { mcReproducibleAsNotBad = false } = {}) {
+    async getSummary(dataPassId, { mcReproducibleAsNotBad = false, runNumber } = {}) {


I suggest you name runNumber something different, to differentiate it from the runNumber you're using in the map function

Sure, I agree.

NarrowsProjects

I'd like you to rename the arguments of getSummary() in GaqService, and i'd like you to reconsider the last signal.aborted check inside _fetchGaqSummaryForCurrentRuns() in RunsPerDataPassOverviewModel

graduta · 2026-02-09T12:42:35Z

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js

        this._markAsSkimmableRequestResult$ = new ObservableData(RemoteData.notAsked());
        this._markAsSkimmableRequestResult$.bubbleTo(this);

+        this._gaqSummary$ = new ObservableData({});


As you use observable data, you can already tell it what the source to look for is rather than doing it on L82

I am not sure how to use it with the asynchronous nature of the summaries.

graduta · 2026-02-09T12:43:32Z

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js

+        this._gaqSummary$ = new ObservableData({});
+        this._gaqSummary$.bubbleTo(this);
+
+        this._gaqSummarySource = null;


This, implies that all the time we will want a sequence in requests but in reality, as soon as we improve the back-end SQL we will want to have all these in parallel. The proposed code design does not allow that.
I would propose that we start with a parallel design in mind already (e.g. using a Map to keep al sources) so that we can quickly migrate to it afterwards

Okay, I originally added this because I was doing it in parallel at the start but removed given we thought best to do in sequence for now. I can add back.

isaachilly added 8 commits January 30, 2026 15:54

[O2B-1528] Fix spelling

5e62f29

Replace misspelled parameter `verifiedd_flags_list` with the correct `verified_flags_list` in QcFlagRepository.

[O2B-1528] Fix typo: verifiedd_flags_list

84aceda

Remove incorrect/duplicated identifier `verifiedd_flags_list` from the destructuring and mapping in QcFlagRepository.

[O2B-1528] Await GAQ summary fetches sequentially

67564ed

Make GAQ summary fetches run sequentially so to ease reduce load on the database.

[O2B-1528] Require runNumber for GAQ summary requests to avoid databa…

b8decec

…se load Make runNumber a required Joi parameter to prevent user stressing the database fetching data for all runs of a dataPass. Intended to be reverted once database query has been optimised.

[O2B-1528] Validate dataPassId and runNumber as positive

9f122fe

Tighten Joi validation for GAQ summary by requiring dataPassId and runNumber to be positive numbers.

[O2B-1528] Update GAQ test with enabling of GAQ summary again

a5768c7

Adjust the runsPerDataPass overview test to match updated row and expected GAQ values.

[O2B-1528] Add validation tests for GAQ summary endpoint

89a09ee

Update qcFlags GAQ summary tests to include runNumber and strengthen request validation coverage.

isaachilly self-assigned this Feb 3, 2026

isaachilly added frontend javascript Pull requests that update Javascript code labels Feb 3, 2026

isaachilly changed the title ~~Improv/o2 b 1528/split gaq summary requests~~ [O2B-1528] Split GAQ summary requests Feb 3, 2026

isaachilly added 4 commits February 3, 2026 10:06

[O2B-1528] Make GAQ summary fetches cancelable

f3533d0

Use RemoteDataSource and AbortController to make per-run GAQ summary fetches cancelable. Can be easily adapted to use an array of remotedatasources if in the future we decide to request them in parallel.

[O2B-1528] Failed to store GAQ summary correctly

f6edc96

When updating the GAQ summary for a run, store the actual success payload instead of the raw remoteData object.

[O2B-1528] Add GAQ summary multiple request test

d020ac8

Add a test that captures outgoing GAQ summary requests and asserts each run triggers exactly one GAQ request.

Merge branch 'main' into improv/O2B-1528/Split-GAQ-summary-requests

e6e6388

isaachilly marked this pull request as ready for review February 4, 2026 15:36

isaachilly requested a review from graduta as a code owner February 4, 2026 15:36

NarrowsProjects reviewed Feb 9, 2026

View reviewed changes

NarrowsProjects requested changes Feb 9, 2026

View reviewed changes

graduta requested changes Feb 9, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[O2B-1528] Split GAQ summary requests#2071

[O2B-1528] Split GAQ summary requests#2071
isaachilly wants to merge 12 commits intomainfrom
improv/O2B-1528/Split-GAQ-summary-requests

isaachilly commented Feb 3, 2026 •

edited

Loading

Uh oh!

codecov bot commented Feb 3, 2026 •

edited

Loading

Uh oh!

NarrowsProjects Feb 9, 2026

Uh oh!

isaachilly Feb 9, 2026 •

edited

Loading

Uh oh!

NarrowsProjects Feb 9, 2026

Uh oh!

isaachilly Feb 9, 2026

Uh oh!

NarrowsProjects Feb 9, 2026

Uh oh!

isaachilly Feb 9, 2026

Uh oh!

NarrowsProjects left a comment

Uh oh!

graduta Feb 9, 2026

Uh oh!

isaachilly Feb 9, 2026

Uh oh!

graduta Feb 9, 2026

Uh oh!

isaachilly Feb 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

isaachilly commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I have a JIRA ticket

Uh oh!

codecov bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

isaachilly Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NarrowsProjects left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

isaachilly commented Feb 3, 2026 •

edited

Loading

codecov bot commented Feb 3, 2026 •

edited

Loading

isaachilly Feb 9, 2026 •

edited

Loading