Skip to content

Add replacement config to generator_pythia8 to replace D*/Sigmac+ by Xic0/Omegac0 #2186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
FDUEnrich wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add replacement config to generator_pythia8 to replace D*/Sigmac+ by Xic0/Omegac0 #2186

FDUEnrich wants to merge 11 commits into from
+410 −22

Conversation

@FDUEnrich
Copy link

@FDUEnrich FDUEnrich commented Nov 19, 2025

No description provided.

@FDUEnrich
Add configuration for GeneratorHF D2H Sigmac+/D* replaced by Omegac0/…
ca18456 
…Xic0
@FDUEnrich
Add Pythia8 configuration for charm hadronic decays
b946646 
This configuration file sets up the Pythia8 generator for charm hadronic processes, specifying decay modes and parameters for various charm and bottom hadrons. It includes detailed channels for D, Ds, Lambda_c, Xi_c, and Omega_c decays, as well as adjustments for resonance decays.
@FDUEnrich
Add replacement config
9b37b4b 
Updated the destructor to clean up the HF generator and modified the setupGeneratorEvHF method to include additional parameters for particle replacement.
@FDUEnrich
Update replaceParticle to include status code check
46c370b 
Refactor replaceParticle function to check status code before replacing particles.
@FDUEnrich FDUEnrich requested a review from a team as a code owner November 19, 2025 15:09
@github-actions
Copy link

github-actions bot commented Nov 19, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1
async-2024-PbPb-apass2
async-2023-PbPb-apass5

fgrosa
fgrosa requested changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@fgrosa fgrosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FDUEnrich thanks a lot for the development!
I have a few comments (see below) and in addition you need to add the test macro corresponding to the new ini file in https://github.com/AliceO2Group/O2DPG/tree/master/MC/config/PWGHF/ini/tests (it is required for every ini file).

FDUEnrich and others added 6 commits November 21, 2025 11:41
@FDUEnrich @fgrosa
Update MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_PbPb_repla…
68a5f34 
…ced.ini

Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
@FDUEnrich
Add pythia8 config for XicOmegaC decays
5a0bd9a
@FDUEnrich @fgrosa
Update MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_PbPb_repla…
4a133cc 
…ced.ini

Co-authored-by: Fabrizio <fabrizio.grosa@cern.ch>
@FDUEnrich
Keep only charm baryon decay modes
7eb8a8c 
Updated decay modes for charm baryons and added new channels for Omega_c decays.
@FDUEnrich
Add GeneratorHF_D2H_ccbar_and_bbbar_PbPb_replaced teat
bc22810 
Test if the replacements and the decay model are correct.
@FDUEnrich
Merge branch 'AliceO2Group:master' into master
986c8ba
@FDUEnrich FDUEnrich requested a review from fgrosa November 23, 2025 18:15
@fgrosa
Copy link
Contributor

fgrosa commented Nov 24, 2025 •
edited
Loading

@klsmith15k apparently the test macro for GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons_pp_ref.ini that you committed is missing. Can you please implement it and open a PR? Thanks!

@klsmith15k
Copy link
Contributor

klsmith15k commented Dec 4, 2025

@fgrosa I apologize for the delay! I followed your instructions and uploaded the test macro with a new PR here. Please let me know if there are any further issues

@fgrosa
Copy link
Contributor

fgrosa commented Dec 5, 2025

Hi @jackal1-66 @sawenzel would it be possible to restart the tests for this PR? The error should have been solved in #2199. Many thanks!

@fgrosa fgrosa mentioned this pull request Dec 9, 2025
Merged
@jackal1-66
Copy link
Collaborator

jackal1-66 commented Dec 15, 2025

Hello, there are few tests still failing:

Test 16: /O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay_pp_ref.ini with generator External�[0;31m -> FAILED�[0m
�[0;31mError found in log /sw/BUILD/4262584a411a319d977a5ed874161c22135727bc/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/generators/16_GeneratorHF_D2H_bbbar_Mode2_OmegaC_NoDecay_pp_ref.ini_External_dir/o2sim_serverlog�[0m
1384-[11:42:37][INFO] GENEVENT CHANGING STATE TO SERVING
1385-[11:42:37][INFO] Sending 500 particles
1386-[11:42:37][INFO] treating ev 7 part 1 out of 3
1387-[11:42:37][INFO] Sending 500 particles
1388-[11:42:37][INFO] treating ev 7 part 2 out of 3
1389-[11:42:37][INFO] Sending 472 particles
1390-[11:42:37][INFO] treating ev 7 part 3 out of 3
1391-[11:42:37][INFO] Event generation started 
1392-[11:42:37][INFO] GENEVENT CHANGING STATE TO WAITEVENT
1393-
1394: *** Break *** segmentation violation
1395-
1396-
1397-
1398-===========================================================
1399-There was a crash.
1400-This is the entire stack trace of all threads:
1401-===========================================================
1402-
1403-Thread 7 (Thread 0x7fa8061ff600 (LWP 5106) "o2-sim-primary-"):
1404-#0  0x00007fa82807f17a in __futex_abstimed_wait_common () from /lib64/libc.so.6

and

Test 38: /O2DPG/MC/config/PWGHF/ini/GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini with generator External�[0;31m -> FAILED�[0m
�[0;31mError found in log /sw/BUILD/4262584a411a319d977a5ed874161c22135727bc/O2DPG-sim-tests/o2dpg-sim_tests/o2dpg_tests/generators/38_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini_External_dir/o2dpg-test-kine.log�[0m
2-
3-Processing External.C...
4---------------------------------
5-# Events: 100
6-# MB events: 80
7-# events injected with 4 quark pair: 10
8-# events injected with 5 quark pair: 10
9-# signal hadrons: 142
10-# signal hadrons decaying in the correct channel: 127
11-Fraction of signals decaying into the correct channel 0.894366 lower than expected
12:(int) 1

Could you please check them out?

@jackal1-66
Copy link
Collaborator

jackal1-66 commented Dec 15, 2025 •
edited
Loading

Also I checked a bit further and noticed that these tests:

39_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2.ini
9_GeneratorHFTrigger_Xi_Omega_C.ini
7_GeneratorHFTrigger_OmegaCToXiPi.ini
50_GeneratorHF_HFe_ccbar_and_bbar_gap5_Mode2.ini
4_GeneratorJPsiHFCorr_ccbar.ini
54_GeneratorHF_mu_bbbar_gap5_Mode2_accLarge_muTrig.ini
22_GeneratorHF_D2H_bbbar_gap5.ini
51_GeneratorHF_mu_bbbar_gap3_Mode2_accSmall.ini
45_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_corrBkgSigmaC.ini
55_GeneratorHF_mu_bbbar_gap5_Mode2_accSmall.ini
52_GeneratorHF_mu_bbbar_gap5_Mode2_accInt_muTrig.ini
34_GeneratorHF_D2H_ccbar_and_bbbar_gap3_Mode2.ini
10_GeneratorHFTrigger_bbbar.ini
37_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DReso.ini
8_GeneratorHFTrigger_XiCToXiPi.ini
38_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini
36_GeneratorHF_D2H_ccbar_and_bbbar_gap5.ini
41_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons_pp_ref.ini
25_GeneratorHF_D2H_ccbar_Mode2_OmegaC_NoDecay_pp_ref.ini
40_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons.ini
46_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_pp_ref.ini
48_GeneratorHF_D2H_ccbar_and_bbbar_gap8_Mode2_XiC.ini
33_GeneratorHF_D2H_ccbar_and_bbbar_gap3.ini
42_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_XiC.ini
44_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_corrBkg.ini
43_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_XiC_OmegaC.ini
12_GeneratorHF_D2H_bbbar_Bforced_gap5_Mode2.ini
6_GeneratorHFTrigger_Bforced.ini
35_GeneratorHF_D2H_ccbar_and_bbbar_gap3_Mode2_XiC.ini
13_GeneratorHF_D2H_bbbar_BtoDK_gap5_Mode2.ini

Generate more than 2000 Pythia events to complete. Could you please add the line #NEV_TEST> 10 at the beginning of these ini files? They will reduce the required events from 100 to 10, which should be enough for testing, while reducing significantly the processing time.

@fgrosa
Copy link
Contributor

fgrosa commented Dec 15, 2025

Also I checked a bit further and noticed that these tests:

39_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2.ini
9_GeneratorHFTrigger_Xi_Omega_C.ini
7_GeneratorHFTrigger_OmegaCToXiPi.ini
50_GeneratorHF_HFe_ccbar_and_bbar_gap5_Mode2.ini
4_GeneratorJPsiHFCorr_ccbar.ini
54_GeneratorHF_mu_bbbar_gap5_Mode2_accLarge_muTrig.ini
22_GeneratorHF_D2H_bbbar_gap5.ini
51_GeneratorHF_mu_bbbar_gap3_Mode2_accSmall.ini
45_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_corrBkgSigmaC.ini
55_GeneratorHF_mu_bbbar_gap5_Mode2_accSmall.ini
52_GeneratorHF_mu_bbbar_gap5_Mode2_accInt_muTrig.ini
34_GeneratorHF_D2H_ccbar_and_bbbar_gap3_Mode2.ini
10_GeneratorHFTrigger_bbbar.ini
37_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DReso.ini
8_GeneratorHFTrigger_XiCToXiPi.ini
38_GeneratorHF_D2H_ccbar_and_bbbar_gap5_DResoTrigger.ini
36_GeneratorHF_D2H_ccbar_and_bbbar_gap5.ini
41_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons_pp_ref.ini
25_GeneratorHF_D2H_ccbar_Mode2_OmegaC_NoDecay_pp_ref.ini
40_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_CharmBaryons.ini
46_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_pp_ref.ini
48_GeneratorHF_D2H_ccbar_and_bbbar_gap8_Mode2_XiC.ini
33_GeneratorHF_D2H_ccbar_and_bbbar_gap3.ini
42_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_XiC.ini
44_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_corrBkg.ini
43_GeneratorHF_D2H_ccbar_and_bbbar_gap5_Mode2_XiC_OmegaC.ini
12_GeneratorHF_D2H_bbbar_Bforced_gap5_Mode2.ini
6_GeneratorHFTrigger_Bforced.ini
35_GeneratorHF_D2H_ccbar_and_bbbar_gap3_Mode2_XiC.ini
13_GeneratorHF_D2H_bbbar_BtoDK_gap5_Mode2.ini

Generate more than 2000 Pythia events to complete. Could you please add the line #NEV_TEST> 10 at the beginning of these ini files? They will reduce the required events from 100 to 10, which should be enough for testing, while reducing significantly the processing time.

Hi @jackal1-66 thanks a lot for the suggestion! I reduced the number of test events in this PR #2216. I also fixed the ones crashing, and reduced even more than 10 the number for few ini files that trigger on very rare particles (hence the actual generation of events is much much larger than 5, order of ~100k actually)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgrosa fgrosa fgrosa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FDUEnrich @fgrosa @klsmith15k @jackal1-66