Modularise sim WF #446
Draft
Modularise sim WF #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benedikt-voelkel
requested review from
chiarazampolli,
gconesab and
sawenzel
as code owners
benedikt-voelkel
force-pushed
the
sim-wf-modularise
branch
from
a61c023 to
51d384a
Compare
benedikt-voelkel
force-pushed
the
sim-wf-modularise
branch
2 times, most recently
from
72f93fc to
9f04f10
Compare
benedikt-voelkel
force-pushed
the
sim-wf-modularise
branch
from
9f04f10 to
906a188
Compare
* add o2dpg_sim_workflow_evolution.py providing several
modularisation features
* possible to select modules to be simulated using --modules
* possible to select detectors to be read out using --readout-detectors
* tasks requiring inactive detectors are not added
* allows for transport only using specified detectors/passive modules
* digi, reco and match introduced as logical steps
* consrtuct e.g. a digit task with add_digi_task
specify detector, task name constructed automatically
* get dependency e.g. with get_digit_need
* automatic construction of source strings (e.g. used for vertexing
commands or aod producer)
this again returns a string only including of sources actually present
based on reco and match tasks that have been successfully added
* still possible to construct any task explicitly with name, needs etc
as before
* some tasks adjusted to their minimal dependencies
* small adjustments in o2dpg_qc_finalization_workflow.py to have same
"<taskname>_<timeframe>" format of tasknames per timeframe
benedikt-voelkel
force-pushed
the
sim-wf-modularise
branch
from
906a188 to
b14a076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible to select modules to be simulated using --modules
possible to select detectors to be read out using --readout-detectors
tasks requiring inactive detectors are not added
allows for transport only using specified detectors/passive modules
digi, reco and match introduced as logical steps
consrtuct e.g. a digit task with add_digi_task
specify detector, task name constructed automatically
get dependency e.g. with get_digit_need
automatic construction of source strings (e.g. used for vertexing
commands or aod producer)
this again returns a string only including of sources actually present
based on reco and match tasks that have been successfully added
still possible to construct any task explicitly with name, needs etc
as before
some tasks adjusted to their minimal dependencies
small adjustments in o2dpg_qc_finalization_workflow.py to have same
"_" format of tasknames per timeframe