[PWGJE] Fix wrong headers. Remove unused files. Fix includes. #14128
Conversation
|
O2 linter results: ❌ 425 errors, |
github-actions
bot
changed the title
vkucera
changed the title
vkucera
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
@nzardosh I have validated that |
| Configurable<std::vector<double>> trackingEfficiency{"trackingEfficiency", {1.0, 1.0}, "tracking efficiency array applied to jet finding if applyTrackingEfficiency is true"}; | ||
|
|
||
| Service<o2::framework::O2DatabasePDG> pdg; | ||
| o2::framework::Configurable<float> zCut{"zCut", 0.1, "soft drop z cut"}; |
There was a problem hiding this comment.
what is the benefit of not including these common o2 namespaces in the .h files? it seems to me that every single o2 task needs these namespaces so it just seems it makes the headers more complex to read if we remove them
There was a problem hiding this comment.
using directives are forbidden in the global scope of headers for many important reasons.
|
thanks for checking vit! I am happy with the headers being moved but I am less sure that making the namespaces explicit in the headers is practical. particularly the ones that are used in every single task. |
3 participants
cxxfiles.cxxfiles wrongly used as headers.h.RecoDecay.