-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGLF] Delete unused source files #14132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
romainschotter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @vkucera !
For what concerns the strangeness, I am not entirely sure why we would like to remove these converters. Usually, converters are meant to ensure backward compatibility, particularly for cases where derived data were produced with an old tag (for debugging or maybe because there is no benefit in regenerating them) but are then analyzed with a newer tag. Could you please elaborate on the motivation for removing them?
Hi @romainschotter , the motivation is in the PR title. These files are unused. |
|
I am still not sure to understand why their removal would be beneficial |
|
The deleted converters cannot be used in the current setup because there are no CMake commands to compile them. I propose the following:
Please let me know what you prefer. In case you wish to keep them, please make sure that the bugs currently reported by the analysis tools are fixed soon. |
|
Hi @vkucera ! |
|
Hi @romainschotter , I tried to add the CMake commands but |
|
Restored the deleted converters. |
Requires #14211