Skip to content

[PWGLF] simplified derived data model with task to speed up the calibration process #14206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
abmodak merged 5 commits into from
Dec 18, 2025
Merged

[PWGLF] simplified derived data model with task to speed up the calibration process #14206

abmodak merged 5 commits into from
Dec 18, 2025

Conversation

@prottayCMT
Copy link
Contributor

@prottayCMT prottayCMT commented Dec 14, 2025

No description provided.

@github-actions github-actions bot changed the title simplified derived data model with task to speed up the calibration process [PWGLF] simplified derived data model with task to speed up the calibration process Dec 14, 2025
@github-actions
Copy link

github-actions bot commented Dec 14, 2025 •
edited
Loading

O2 linter results: ❌ 8 errors, ⚠️ 15 warnings, 🔕 0 disabled

@prottayCMT prottayCMT marked this pull request as ready for review December 14, 2025 11:34
romainschotter
romainschotter requested changes Dec 14, 2025
View reviewed changes
Copy link
Collaborator

@romainschotter romainschotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prottayCMT ! It looks good to me! Since you are adding new files, can you please address the O2Linter errors associated to those files (such that these errors won't have to be addressed later)? Thank you very much!

@alibuild
Copy link
Collaborator

alibuild commented Dec 16, 2025

Error while checking build/O2Physics/o2 for beb2dde at 2025-12-16 01:05:

No log files found

Full log here.

@prottayCMT
Copy link
Contributor Author

prottayCMT commented Dec 16, 2025

Hi @prottayCMT ! It looks good to me! Since you are adding new files, can you please address the O2Linter errors associated to those files (such that these errors won't have to be addressed later)? Thank you very much!

Hi @romainschotter most of the major linter errors are taken care of related to my task.....can u approve?

@alibuild
Copy link
Collaborator

alibuild commented Dec 16, 2025

Error while checking build/O2Physics/o2 for e173e84 at 2025-12-16 20:29:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14206-slc9_x86-64/0/PWGLF/Tasks/Strangeness/zdccalderived.cxx:403:39: error: comparison of integer expressions of different signedness: 'std::size_t' {aka 'long unsigned int'} and 'int' [-Werror=sign-compare]
/sw/SOURCES/O2Physics/14206-slc9_x86-64/0/PWGLF/TableProducer/Common/zdcvector.cxx:246:39: error: comparison of integer expressions of different signedness: 'std::size_t' {aka 'long unsigned int'} and 'int' [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

romainschotter
romainschotter previously approved these changes Dec 17, 2025
View reviewed changes
vkucera
vkucera reviewed Dec 17, 2025
View reviewed changes
PWGLF/Tasks/Strangeness/zdccalderived.cxx
Comment on lines 53 to 60
#include <array>
#include <chrono>
#include <cmath>
// #include <iostream>
#include "Framework/Logger.h"

#include <string>
#include <vector>
Copy link
Collaborator

@vkucera vkucera Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. Don't leave comments in between. They break the sorting.

Copy link
Contributor Author

@prottayCMT prottayCMT Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vkucera done...can you approve now as i need the tomorrow's tag....

Copy link
Collaborator

@vkucera vkucera Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I cannot (and should not) approve.

@ercolessi ercolessi enabled auto-merge (squash) December 17, 2025 16:51
@prottayCMT
Copy link
Contributor Author

prottayCMT commented Dec 17, 2025

@mpuccio could you merge this PR?

@abmodak abmodak disabled auto-merge December 17, 2025 22:31
@abmodak abmodak enabled auto-merge (squash) December 17, 2025 22:31
@abmodak abmodak merged commit 6cf398f into AliceO2Group:master Dec 18, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@mpuccio mpuccio mpuccio approved these changes

@romainschotter romainschotter romainschotter approved these changes

@ercolessi ercolessi ercolessi approved these changes

@abmodak abmodak abmodak approved these changes

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner

@fmazzasc fmazzasc Awaiting requested review from fmazzasc fmazzasc is a code owner

@maciacco maciacco Awaiting requested review from maciacco maciacco is a code owner

@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner

@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner

Assignees

No one assigned

Labels

datamodel pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@prottayCMT @alibuild @mpuccio @vkucera @romainschotter @ercolessi @abmodak