-
Notifications
You must be signed in to change notification settings - Fork 613
[PWGCF] Add PID QA and MCprocess for efficiency #14253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
O2 linter results: ❌ 0 errors, |
|
Error while checking build/O2Physics/o2 for 70f464a at 2025-12-17 10:55: Full log here. |
|
Error while checking build/O2Physics/o2 for 40592ce at 2025-12-17 12:51: Full log here. |
|
@fuchuncui You are supposed to test the compilation before making the PR. |
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx
Outdated
| * @details default datas are from run2, note that separate pi-k and k-p needs to use difference pt range | ||
| */ | ||
| // separate pi and k | ||
| O2_DEFINE_CONFIGURABLE(cfgPtMin4ITS_pi_k, float, 0.2, "pt min for ITS to separate pi and k"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow naming conventions
PWGCF/Flow/Tasks/pidFlowPtCorr.cxx
Outdated
| * If the track pt is out of a detector's valid range, that detector's check is skipped. | ||
| */ | ||
| template <typename TrackObject> | ||
| bool isPion(TrackObject track) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't take by value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fuchuncui, @vkucera is right
If the track is passed by value, as it is now, a full copy of the complete track is passed to the function which is a waste of resources.
It has to be passed by reference, isPion(TrackObject const &track), so that only the reference to the track is then passed to the function
Add batter PID check and QA,
Add run by run NUA output,
Add MCprocess for NUE correction. (by Qiuyu Xia, https://github.com/huinaibing)
Fix a bug in V0s and cascades ITS PID selection.