Skip to content

[Common] Support parameter inheritance of vectors of strings #14276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
njacazio merged 1 commit into from
Dec 18, 2025
+5 −0
Merged

[Common] Support parameter inheritance of vectors of strings #14276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Common/Core/TableHelper.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#include <Framework/RunningWorkflowInfo.h>

#include <string>
#include <vector>

namespace o2::common::core
{
Expand Down Expand Up @@ -81,7 +82,7 @@
}
if (device.name == taskName) { // Found the mother task
int optionCounter = 0;
for (const o2::framework::ConfigParamSpec& option : device.options) {

Check failure on line 85 in Common/Core/TableHelper.h

View workflow job for this annotation

GitHub Actions / O2 linter

[const-ref-in-for-loop] 

Use constant references for non-modified iterators in range-based for loops.
if (verbose) {
LOG(info) << " Option " << optionCounter++ << " " << option.name << " of type " << static_cast<int>(option.type) << " = '" << option.defaultValue.asString() << "'";
}
Expand All @@ -89,6 +90,10 @@
value = option.defaultValue.get<ValueType>();
if (verbose) {
if constexpr (!std::is_same_v<ValueType, o2::framework::LabeledArray<float>>) {
LOG(info) << " Found option '" << optName << " of type LabeledArray<float>";
} else if constexpr (!std::is_same_v<ValueType, std::vector<std::string>>) {
LOG(info) << " Found option '" << optName << " of type vector<string>";
} else {
LOG(info) << " Found option '" << optName << "' with value '" << value << "'";
}
found = true;
Expand Down
Loading