[PWGLF] Omegahm #14279
Merged
[PWGLF] Omegahm #14279
+160
−90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
O2 linter results: ❌ 34 errors, |
lietava
requested review from
alibuild,
ercolessi,
mpuccio,
romainschotter and
skundu692
as code owners
Collaborator
|
@lietava Please use a meaningful PR title. |
vkucera
reviewed
Dec 18, 2025
| if (std::abs(mcp.eta()) > 0.5f) | ||
| continue; | ||
| int q = 0; | ||
| if (auto pdg = TDatabasePDG::Instance()->GetParticle(mcp.pdgCode())) { |
Collaborator
There was a problem hiding this comment.
Why do you still use TDatabasePDG::Instance?
Collaborator
Author
There was a problem hiding this comment.
What do you mean ? What should I use ?
Collaborator
There was a problem hiding this comment.
You should use Service<o2::framework::O2DatabasePDG>, as the linter suggests.
Collaborator
Author
There was a problem hiding this comment.
ok, fix in the next pr. Thanks.
romainschotter
approved these changes
Dec 18, 2025
Collaborator
Author
I will do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory leaks fixes and speed optimisation