[PWGHF] Fix V0/casc. MC matching in HF PID task. #14289
Merged
+15
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfaggin
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mmazzilli,
stefanopolitano,
vkucera and
zhangbiao-phy
as code owners
|
O2 linter results: ❌ 0 errors, |
Collaborator
Author
|
tagging also the authors of the code @fchinu @Marcellocosti @Luca610 @stefanopolitano |
Collaborator
Author
|
putting the PR to draft to address a major fix proposed by @romainschotter , many thanks! |
Collaborator
Author
|
thanks a lot to @romainschotter for pointing me to the solution, now the code works w/o exceptions |
mfaggin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ddobrigk @romainschotter here the PR that fixes the crashing problem in my case. Here we simply skip all the V0/casc. that point to a MC particle with ID outside the MC table and for the purposes of the task is not relevant, but maybe it's helpful for you.