[Common] Add zdc-extra-table-reader task#16028
Open
udmitrie wants to merge 7 commits intoAliceO2Group:masterfrom
Open
[Common] Add zdc-extra-table-reader task#16028udmitrie wants to merge 7 commits intoAliceO2Group:masterfrom
udmitrie wants to merge 7 commits intoAliceO2Group:masterfrom
Conversation
zdc-extra-table-reader is needed to read AOD/ZDCEXTRA derived data and proceed with multistep calibration (Q-vectors recentering) of ZDC data
|
O2 linter results: ❌ 1 errors, |
Refactor logging and constants in zdcExtraTableReader. Replaced std::cerr logging with LOGF for error handling and updated constant names for consistency.
udmitrie
requested review from
a team,
alibuild,
ddobrigk,
dsekihat,
iarsene,
jgrosseo and
ktf
as code owners
Add check number of fired towers with isZN*SpDeterminable (to reconstruct Q-vector at least 2 fired towers needed); Replace FindBin with FindFixBin; update variables.
Please consider the following formatting changes to AliceO2Group#16028
Contributor
Author
|
Dear code owners, There are no O2 linter errors connected to my changes. |
vkucera
reviewed
May 6, 2026
| #include <Framework/OutputObjHeader.h> | ||
| #include <Framework/runDataProcessing.h> | ||
|
|
||
| #include <TFile.h> |
vkucera
reviewed
May 6, 2026
Comment on lines
+311
to
+312
| {}, | ||
| OutputObjHandlingPolicy::AnalysisObject}; |
vkucera
reviewed
May 6, 2026
Comment on lines
+315
to
+324
| evSel_zvtx, | ||
| evSel_sel8, | ||
| evSel_occupancy, | ||
| evSel_kNoSameBunchPileup, | ||
| evSel_kIsGoodZvtxFT0vsPV, | ||
| evSel_kNoCollInTimeRangeStandard, | ||
| evSel_kIsVertexITSTPC, | ||
| evSel_kIsGoodITSLayersAll, | ||
| evSel_allEvents, | ||
| nEventSelections |
Collaborator
There was a problem hiding this comment.
Follow the naming conventions.
vkucera
reviewed
May 6, 2026
|
|
||
| void clearCache() | ||
| { | ||
| if (hMeanVx) { |
Collaborator
There was a problem hiding this comment.
The if condition is redundant.
vkucera
reviewed
May 6, 2026
Comment on lines
+357
to
+360
| delete step.hMeanQxZNA; | ||
| delete step.hMeanQyZNA; | ||
| delete step.hMeanQxZNC; | ||
| delete step.hMeanQyZNC; |
Collaborator
There was a problem hiding this comment.
Why is this not in ~CalibStepData?
vkucera
reviewed
May 6, 2026
| } | ||
| mCurrentRunNumber = mRunNumber; | ||
|
|
||
| if (gEventCounter.find(mRunNumber) == gEventCounter.end()) { |
Collaborator
There was a problem hiding this comment.
This is not a sequential container. Use contains to check the presence of a key.
vkucera
reviewed
May 6, 2026
| // Vertex Calibration | ||
| if (ifBeamSpotCorrection) { | ||
| std::string folder = Form("%s/step0", qRecenteringCcdb.value.c_str()); | ||
| TList* lst = ccdb->getForRun<TList>(folder, run); |
Collaborator
There was a problem hiding this comment.
Don't duplicate the type.
Suggested change
| TList* lst = ccdb->getForRun<TList>(folder, run); | |
| auto* lst = ccdb->getForRun<TList>(folder, run); |
vkucera
reviewed
May 6, 2026
Comment on lines
+635
to
+637
| } else { | ||
| LOGF(error, " >> CCDB TList is NULL for path: %s. Check object type (TList vs TFile).", folder.c_str()); | ||
| } |
Collaborator
There was a problem hiding this comment.
Reverse the logic to return early if (!lst) and reduce nesting.
vkucera
reviewed
May 6, 2026
|
|
||
| // Fill histogram for all bits that passed | ||
| for (int bit = 0; bit < nEventSelections + 1; bit++) { | ||
| if (zdc.selectionBits() & (1 << bit)) { |
Collaborator
There was a problem hiding this comment.
There is TESTBIT for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zdc-extra-table-reader is needed to read AOD/ZDCEXTRA derived data and proceed with multi-step calibration (Q-vectors recentering) of ZDC data