[PWGLF] Added configurable for MID#16511
Conversation
5ub-Man
requested review from
alibuild,
dmallick2,
mpuccio,
omvazque,
prottayCMT,
skundu692 and
smaff92
as code owners
github-actions
Bot
changed the title
|
O2 linter results: ❌ 0 errors, |
| Configurable<float> pionMIDpTlow{"pionMIDpTlow", 1.0, "Low pT cut for pion in MID"}; | ||
| Configurable<float> pionMIDpThigh{"pionMIDpThigh", 2.5, "High pT cut for pion in MID"}; | ||
| Configurable<float> kaonMIDpTlow{"kaonMIDpTlow", 0.7, "Low pT cut for kaon in MID"}; | ||
| Configurable<float> kaonMIDpThigh{"kaonMIDpThigh", 2.5, "High pT cut for kaon in MID"}; |
There was a problem hiding this comment.
Please use proper lowerCamelCase. I doubt that you want to configure any thighs.
There was a problem hiding this comment.
- Do not mark suggestions as resolved. Please read the contribution guidelines.
- You still don't use
lowerCamelCase.
There was a problem hiding this comment.
-
Sorry @vkucera for marking the suggestion as resolved. I'll keep this in mind
-
I changed the variable names from
pionMIDpTlowtopionMIDpTLowetc. following thelowerCamelCaseformat. Could you please give me an example of what you want me to do so that I can fix this in my next PR? Do you want it to be likepionMIDPtLowor anything else? Thank you for your help.
There was a problem hiding this comment.
The proper lowerCamelCase name is pionMidPtLow. If you are not sure how to form the correct name, I recommend this definition: https://google.github.io/styleguide/javaguide.html#s5.3-camel-case
3 participants
No description provided.