[PWGLF] update of kstarInOO.cxx#16760
Merged
Merged
Conversation
JimunLee
requested review from
alibuild,
dmallick2,
mpuccio,
omvazque,
prottayCMT,
skundu692 and
smaff92
as code owners
|
O2 linter results: ❌ 112 errors, |
Collaborator
|
Please use a meaningful PR title and fix the errors and warnings. |
smaff92
approved these changes
Jun 23, 2026
Collaborator
|
@smaff92 Please don't merge PRs which introduce errors or have vague titles. |
Collaborator
|
Hi @vkucera, Sorry, maybe I missed something, but the latest push cleared all checks except for O2 linter (which is not mandatory), which is fine, no? With respect to the title, I sort-of agree that the title is a bit vague, but simultaneously, looking through the actual changes to the code, it is a large overhaul over many different areas of the code, so it is difficult to pinpoint the title to a single change. What name would you have suggested for the title, for future reference? Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear experts,
The jet Analysis part has been added.
Thank you,
Jimun