[OGUI-1661] Object tree breaking when collapsing parents without first collapsing children #3234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
graduta
requested changes
Dec 16, 2025
graduta
requested changes
Dec 17, 2025
| open ? iconCaretBottom : iconCaretRight, | ||
| '', | ||
| { | ||
| paddingLeft: `${level + 0.25}em`, |
Member
There was a problem hiding this comment.
You do not need the padding at all now after the refactor.
You also removed the span element, so the default padding of 0.3 from table element is now applied.
Remove the paddingLeft from the call of treeRowElement both places and you will see it looks like before which is what we want
Collaborator
Author
There was a problem hiding this comment.
As discussed, paddingLeft controls the tree indentation and is therefore required.
| ' ', | ||
| tree.name, | ||
| h('td.highlight.flex-row.items-center.g1', { | ||
| style: styling, |
Member
There was a problem hiding this comment.
Given that you are not applying any chances, why not naming the variable style and use the short version { style }?
| key: path, title: path, onclick: selectItem, class: className, id: path, | ||
| key, | ||
| id: key, | ||
| title: name, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
To fix the issue the following has been done:
mapwithflatMapin recursive treeRow traversalIn addition to this:
notify()calls during deep tree operations