Skip to content

[OGUI-1847] Fix arrays saved as objects and other small fixes #3236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Deaponn wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

[OGUI-1847] Fix arrays saved as objects and other small fixes #3236

Deaponn wants to merge 4 commits into from

Conversation

@Deaponn
Copy link
Collaborator

@Deaponn Deaponn commented Dec 15, 2025

This PR fixes a couple of bugs:

  • one where arrays are converted into objects on configuration save ([true, 'text', 99] becomes { 0: true, 1: 'text', 2: 99 })
  • one where edit difference highlighting fails for FormToggleInput component
  • one where empty objects and lists are not parsed correctly which causes them to be lost while saving

I have JIRA issue created

  • branch and/or PR name(s) includes JIRA ID
  • issue "Status" is set to "In review"
  • PR labels are selected

@Deaponn Deaponn requested a review from graduta as a code owner December 15, 2025 08:53
piechnikk
piechnikk approved these changes Dec 16, 2025
View reviewed changes
Copy link
Collaborator

@piechnikk piechnikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piechnikk piechnikk piechnikk approved these changes

@sKrzysieK sKrzysieK sKrzysieK approved these changes

@graduta graduta Awaiting requested review from graduta graduta is a code owner

Assignees

No one assigned

Labels

Configuration GUI

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Deaponn @piechnikk @sKrzysieK