[OGUI-1844] Implementation of database service-controller structure and seeding creations #3245

dwedr · 2025-12-18T04:49:51Z

I have JIRA issue created

branch and/or PR name(s) includes JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected
FLP integration tests were ran successful

Implementation of database call structure, including seeding for both Vault and the database, along with integration tests verifying the seeded data. Updated related files and configurations accordingly.

This reverts commit cf9eb12.

This reverts commit 76cc4ca.

This reverts commit b948f1c.

This reverts commit cf9eb12.

…lt feature

…dy for injecting querries for endpoints

Tokenization/backend/central-system/src/lib/database/Database.ts

Tokenization/backend/central-system/src/lib/database/utils/expireToken.ts

Tokenization/backend/central-system/src/services/VaultCreateKeyService.ts

Tokenization/backend/central-system/tests/DatabaseTests/DatabaseIntegration.spec.ts

Copilot

Pull request overview

This PR implements a comprehensive database and Vault infrastructure for the Tokenization service, including seeding, migrations, integration tests, and CI/CD updates.

Purpose: Establish database service-controller structure with automated seeding for both Vault and the database, along with integration tests to verify seeded data.

Key Changes:

Database infrastructure with Sequelize ORM, migrations, and seeders
Vault integration with certificate-based authentication and key management
Comprehensive test suite including unit and integration tests
Docker Compose orchestration for local development and testing

Reviewed changes

Copilot reviewed 68 out of 74 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
`scripts/actions-certificates-creation.sh`	Generates test certificates for Vault and clients
`docker/vault/vault-setup.sh`	Initializes and configures Vault with policies and secrets
`docker/database/populate/*.sql`	Database and user creation scripts
`docker-compose*.yml`	Updated service orchestration with Vault and database dependencies
`backend/central-system/src/lib/database/*`	Database models, migrations, seeders, and Sequelize configuration
`backend/central-system/src/controllers/VaultController.ts`	Vault operations controller with event bus integration
`backend/central-system/src/services/Vault*.ts`	Vault service implementations (auth, sign, encrypt, credentials)
`backend/central-system/tests/*/Integration.spec.ts`	Integration tests for Vault and database
`.github/workflows/tokenization.yml`	Updated CI pipeline with certificate generation and extended tests

Files not reviewed (2)

Tokenization/backend/central-system/package-lock.json: Language not supported
Tokenization/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-18T04:55:09Z

Tokenization/scripts/actions-certificates-creation.sh

@@ -0,0 +1,135 @@
+#!/usr/bin/env bash


The title in the PR metadata contains a typo: "[OGUI-1844}" should use a closing bracket "]" instead of a closing brace "}".

Copilot · 2025-12-18T04:55:10Z

Tokenization/backend/central-system/tests/VaultTests/VaultAuthService.spec.ts

+    ).rejects.toThrow('error');
+  });
+
+  it('renew() connects with proper token and reutrns renwed token', async () => {


There's a typo in the comment. "reutrns" should be "returns".

Copilot · 2025-12-18T04:55:10Z

Tokenization/backend/central-system/src/lib/utils/encrypt.ts

+import  {importSPKI, CompactEncrypt } from 'jose';
+
+
+/** * @description Encrypts data using a provided public key with RSA-OAEP-256 and A256GCM.


The comment has inconsistent spacing. There's an extra space between "/" and the actual comment text. Should be formatted as "/ * @description..." without the extra space.

Copilot · 2025-12-18T04:55:10Z

Tokenization/backend/central-system/src/controllers/VaultController.ts

+
+  /**
+   *  @description Registers the event handlers for vault-related operations.
+   *  This method sets up handlers for signing tokens, logging in, renewing tokens, encyption,


Typo in comment: "encyption" should be "encryption".

Suggested change

* This method sets up handlers for signing tokens, logging in, renewing tokens, encyption,

* This method sets up handlers for signing tokens, logging in, renewing tokens, encryption,

Copilot · 2025-12-18T04:55:11Z

Tokenization/backend/central-system/src/lib/database/Database.ts

+ * or submit itself to any jurisdiction.
+ */
+
+import { log } from 'console';


Unused import log.

Suggested change

import { log } from 'console';

Copilot · 2025-12-18T04:55:12Z

Tokenization/backend/central-system/src/lib/database/utils/expireToken.ts

+
+type Method = 'GET' | 'POST' | 'PUT' | 'DELETE' | string;
+
+const logger = LogManager.getLogger('database/utils/expireToken');


Unused variable logger.

Copilot · 2025-12-18T04:55:12Z

Tokenization/backend/central-system/src/services/VaultCreateKeyService.ts

+    body: Buffer | string | NodeJS.ReadableStream | null
+  ): Promise<void> {
+    try {
+      const resp = await axios.post(url, body, {


Unused variable resp.

Copilot · 2025-12-18T04:55:12Z

Tokenization/backend/central-system/tests/DatabaseTests/DatabaseIntegration.spec.ts

+import { db } from '../../dist/lib/database/Database.js';
+
+describe('Database - integration (seed verification)', () => {
+  let database: SequelizeDatabase;


Unused variable database.

Copilot · 2025-12-18T04:55:13Z

Tokenization/docker/vault/vault-setup.sh

+  echo "$init_output" | sed -n '1,50p'
+


vault-setup.sh logs the full output of vault operator init, which includes the unseal key and initial root token, directly to stdout. Anyone with access to container logs or CI logs can recover these secrets and fully compromise the Vault instance (read/modify any secrets, sign/encrypt data, etc.). Remove the logging of the raw init output and ensure unseal keys/root tokens are only stored in secured locations (e.g., files or secret stores) without ever being printed to logs.

Copilot · 2025-12-18T04:55:13Z

Tokenization/scripts/actions-certificates-creation.sh

+echo "[Vault CI] .env contents:"
+cat "$BACKEND_ENV"


This script prints the generated .env file to stdout, which includes the database password and base64-encoded Vault certificates/keys. Exposing these secrets in CI logs or terminal output allows anyone with log access to reuse the DB credentials or impersonate the Vault client using the leaked private key. Avoid logging the full contents of the .env file and instead only log non-sensitive metadata (e.g., path, presence of variables) while keeping credentials and private keys out of logs.

Tokenization/backend/central-system/tests/DatabaseTests/DatabaseIntegration.spec.ts

dwedr added 30 commits November 8, 2025 03:13

update: added or/and moved dependencies

14529d8

update: change gitingore and added license

9188697

feat: created config helper

e4658b8

feat: created expiring funciton helper

4490ce2

feat: added models

32df2d8

feat: created sequalize functionalities

efdf9da

feat: added job scheduler for setting delay for expirting token

2cb0495

feat: added interfrace

4761ed2

feat: added umzug

6258639

feat: adjusted scripts for dokcer up and down

9f4b465

fix: removed cached files

43680d0

fix: quotes adjustment and script fix

2cbc657

fix: recreated the sctrucure of database creation files and creation way

cd5d505

feat:added 2 first migrations

20b8b29

update: added db instance to central system module

49b974c

fix: database works on docker

042d89a

fix: removed unnecesarry import and type

6e85b43

fix: removed unnecessary import and type

3523ce7

fix: in progress fronted test repairs

66103b5

update: mover environment

cf9eb12

feat: added vault unseal

76cc4ca

fix: removed unseal key from gitthub

b948f1c

fix: adjusted frontend test environment

6915fa3

fix; removed vault from testing

9f2e502

Revert "update: mover environment"

3ceaff9

This reverts commit cf9eb12.

Revert "feat: added vault unseal"

f19cefa

This reverts commit 76cc4ca.

fix: added network aliases

2faf6aa

Revert "fix: removed unseal key from gitthub"

0e487f4

This reverts commit b948f1c.

fix: added env for Vault_Unseal

3592483

Revert "update: mover environment"

0471a7d

This reverts commit cf9eb12.

dwedr added 12 commits December 5, 2025 03:27

update: workflow wihtout preserving env

f4460f4

fix: manually added env to central-system tests

2fe05e0

update: return to first working actions with removed unnecessary job

fa733dc

feat: databse controller first stage version

cecffd7

fix: vault key type change

b65f0d1

update: fixed vault and test and added new encrypt and create key vau…

602a5c1

…lt feature

feat: added new models and migrations for Services and system logs

4506df5

feat: added services structure with empty services and controller rea…

34f05f4

…dy for injecting querries for endpoints

feat: added Route model and seeders umzug feature

c92ffde

feat: added seeding for vault and db

bb0a583

feat: added db seed tests

e64d5b3

feat: seeding and seed testing works

fcf3128

dwedr self-assigned this Dec 18, 2025

Copilot AI review requested due to automatic review settings December 18, 2025 04:49

dwedr added the Tokenization label Dec 18, 2025

dwedr requested a review from graduta as a code owner December 18, 2025 04:49

Copilot started reviewing on behalf of dwedr December 18, 2025 04:50 View session

github-advanced-security bot found potential problems Dec 18, 2025

View reviewed changes

Copilot AI reviewed Dec 18, 2025

View reviewed changes

dwedr changed the title ~~[OGUI-1844} Implementation of database service-controller structure and seeding creations~~ [OGUI-1844] Implementation of database service-controller structure and seeding creations Dec 18, 2025

fix: github copilot fixes

8e95195

github-advanced-security bot found potential problems Dec 18, 2025

View reviewed changes

Tokenization/backend/central-system/tests/DatabaseTests/DatabaseIntegration.spec.ts Fixed Show fixed Hide fixed

dwedr added 8 commits December 18, 2025 06:06

fix: one more copilot fix with delted unused variable

4218da3

fix: testing environment adjustment

d4d7401

feat: table adjustement

0877327

update: tokens seeders update

860cbb3

update: seeders integrity imporvement

7e0eee5

update: Vault and test adjustment

6091683

update: test changes and vault setup

9043db9

feat: added some more files to the strucutre

a4623a0

		import {importSPKI, CompactEncrypt } from 'jose';


		/** * @description Encrypts data using a provided public key with RSA-OAEP-256 and A256GCM.

	* This method sets up handlers for signing tokens, logging in, renewing tokens, encyption,
	* This method sets up handlers for signing tokens, logging in, renewing tokens, encryption,


		type Method = 'GET' \| 'POST' \| 'PUT' \| 'DELETE' \| string;

		const logger = LogManager.getLogger('database/utils/expireToken');

[OGUI-1844] Implementation of database service-controller structure and seeding creations #3245

Are you sure you want to change the base?

[OGUI-1844] Implementation of database service-controller structure and seeding creations #3245

Uh oh!

Conversation

dwedr commented Dec 18, 2025

I have JIRA issue created

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

2 participants