-
Notifications
You must be signed in to change notification settings - Fork 85
fix: prepare dbt review action for v0.8.5 #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
anandgupta42
wants to merge
8
commits into
main
Choose a base branch
from
fix/v0.8.4-dbt-review-launch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+494
−12
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b0d0a8d
fix: prepare dbt review action for v0.8.4
anandgupta42 0503e74
fix: keep review action assets self-contained
anandgupta42 780d5ac
fix: degrade safely on manifest probe errors
anandgupta42 5803b2f
fix: guard optional manifest availability hook
anandgupta42 18d311c
merge main and harden v0.8.5 action release
anandgupta42 26206e0
test: make review e2e assertion platform-stable
anandgupta42 10214aa
test: isolate action review e2e process
anandgupta42 9bca0c5
fix: bound action release lookup
anandgupta42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| import { describe, expect, test } from "bun:test" | ||
| import { writeFileSync } from "node:fs" | ||
| import path from "node:path" | ||
| import { createDispatcherRunner } from "../../src/altimate/review/runner" | ||
| import { tmpdir } from "../fixture/fixture" | ||
|
|
||
| describe("review manifest loading", () => { | ||
| test("loads a valid manifest without initializing the native dispatcher", async () => { | ||
| await using tmp = await tmpdir() | ||
| const manifestPath = path.join(tmp.path, "manifest.json") | ||
| writeFileSync( | ||
| manifestPath, | ||
| JSON.stringify({ | ||
| metadata: { adapter_type: "duckdb" }, | ||
| nodes: { | ||
| "model.demo.orders": { | ||
| resource_type: "model", | ||
| name: "orders", | ||
| original_file_path: "models/orders.sql", | ||
| config: { materialized: "table" }, | ||
| depends_on: { nodes: [] }, | ||
| columns: {}, | ||
| }, | ||
| }, | ||
| sources: {}, | ||
| }), | ||
| ) | ||
|
|
||
| const runner = createDispatcherRunner({ manifestPath }) | ||
| expect(await runner.manifestAvailable?.()).toBe(true) | ||
| expect(await runner.impact("orders")).toEqual({ | ||
| hasManifest: true, | ||
| severity: "SAFE", | ||
| directCount: 0, | ||
| transitiveCount: 0, | ||
| testCount: 0, | ||
| }) | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 changes: 17 additions & 0 deletions
17
packages/opencode/test/install/repository-symlinks.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import { describe, expect, test } from "bun:test" | ||
| import { existsSync, lstatSync, statSync } from "node:fs" | ||
| import path from "node:path" | ||
|
|
||
| const root = path.resolve(import.meta.dir, "../../../..") | ||
| const vscodeImages = ["button-dark.svg", "button-light.svg", "icon.png"] | ||
|
|
||
| describe("release archive assets", () => { | ||
| test("VS Code images are self-contained regular files", () => { | ||
| for (const name of vscodeImages) { | ||
| const asset = path.join(root, "sdks/vscode/images", name) | ||
| expect(existsSync(asset)).toBe(true) | ||
| expect(lstatSync(asset).isSymbolicLink()).toBe(false) | ||
| expect(statSync(asset).size).toBeGreaterThan(0) | ||
| } | ||
| }) | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.