GSOC 2018: Implementing blackholing in Gatekeeper#94
GSOC 2018: Implementing blackholing in Gatekeeper#94gogapp wants to merge 2 commits intoAltraMayor:masterfrom
Conversation
AltraMayor
left a comment
AltraMayor
left a comment
There was a problem hiding this comment.
Implement space saving algorithm
Files .directory, generate_if_map, and lua/if_map.lua don't belong to this pull request.
cjdoucette
left a comment
cjdoucette
left a comment
There was a problem hiding this comment.
The code in include/space_saving.h and lib/space_saving.c should use tabs as indents, not spaces. We also use the DPDK style guidelines for Gatekeeper, which you can find here:
https://doc.dpdk.org/guides/contributing/coding_style.html
Make sure your code abides by these guidelines.
Makefile
Outdated
| APP = gatekeeper | ||
|
|
||
| SRCS-y := main/main.c | ||
| SRCS-y := main/main.c |
There was a problem hiding this comment.
Remove the extra space at the end of this line.
|
Hi mentors, I have added the changes that you have requested. I have also merged the commits into a single meaningful commit. Please note that the implementation is still not fully complete and I am working on the TODOs present in the code. |
lib/space_saving.c
Outdated
| int ret; | ||
|
|
||
| switch(flow->proto) { | ||
| case ETHER_TYPE_IPv4: |
There was a problem hiding this comment.
All of the case statements should be at the same level of indentation as the switch statement.
lib/space_saving.c
Outdated
| { | ||
| int ret; | ||
|
|
||
| switch(flow->proto) { |
There was a problem hiding this comment.
Add a space between switch and the parenthesis.
lib/space_saving.c
Outdated
| int ret; | ||
|
|
||
| switch(flow->proto) { | ||
| case ETHER_TYPE_IPv4: |
There was a problem hiding this comment.
Same thing here: add a space and bring everything inside of this switch back one level of indentation.
| ct_hash_params->hash_func_init_val = 0; | ||
| ct_hash_params->reserved = 0; | ||
|
|
||
| char ct_name[64]; |
There was a problem hiding this comment.
This should be declared at the top of the function, not in the middle.
lib/space_saving.c
Outdated
| * after testing. | ||
| */ | ||
|
|
||
| if(ipv4_if_configured(iface)) { |
There was a problem hiding this comment.
Add a space after the if and before the parenthesis. Look through the rest of the code for similar cases.
gogapp
changed the title
|
I have added the code files for the final review and fixed the styling errors. For testing of the algorithms, I have created a different repository here. https://github.com/gogapp/GSOC-2018-tests |
|
Can you rebase your code to include one commit to add the space saving algorithm and one commit to add the RHHH algorithm? In other words, we shouldn't have a separate commit for fixing the style issues. Also, the Gatekeeper code does not call the functions you are adding. To merge these changes we will need to have it actually integrated with Gatekeeper. |
gogapp
force-pushed
the
space_saving
branch
from
49d6975 to
511f606
Compare
gogapp
force-pushed
the
space_saving
branch
from
511f606 to
fa6f231
Compare
|
I have rebased the commits as requested. To get the changes integrated with Gatekeeper, I need to think out ways to do this. Currently I am focusing on my College Placements. I will integrate the functions with Gatekeeper as soon as I am free. |
|
Suggestion for where to integrate: |
AltraMayor
force-pushed
the
master
branch
4 times, most recently
from
436ab22 to
e52bbf2
Compare
3 participants
This PR implements space saving algorithm in Gatekeeper.