Fixes #21 — Infinite rotate animation around Z axis does not loop as expected on iOS#25
Merged
janicduplessis merged 2 commits intomainfrom Apr 5, 2026
Merged
Fixes #21 — Infinite rotate animation around Z axis does not loop as expected on iOS#25janicduplessis merged 2 commits intomainfrom
janicduplessis merged 2 commits intomainfrom
Conversation
On iOS, initial transform animations were composed into a single CATransform3D matrix and animated via the "transform" key path. This caused rotate 0→360 with loop to silently fail because both matrices are mathematically identical (cos(2π) = cos(0)). Switch the first-mount code path to animate each changed sub-property individually using key paths like transform.rotation.z, transform.scale.x, etc. This lets Core Animation interpolate raw angle values correctly, enabling seamless infinite rotation loops. Closes #21
Adds SpinDemo with two examples: - Infinite Z-axis rotation with loop: 'repeat' - Rotation + scale with loop: 'reverse'
janicduplessis
force-pushed
the
eq/fix-loop
branch
from
b333f10 to
e2b6d55
Compare
janicduplessis
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #21
Root cause: On iOS, initial transform animations were composed into a single CATransform3D matrix and animated via the
transform key path. When animating rotate: 0 → 360, both the initial and target matrices are mathematically identical
(cos(2π) = cos(0)), so CATransform3DEqualToTransform returned YES and the animation was silently skipped. Android was not
affected since it already animates per-property using ObjectAnimator.
Fix: Refactored the iOS first-mount code path to animate each transform sub-property individually using Core Animation key
paths (transform.rotation.z, transform.scale.x, transform.translation.x, etc.) instead of interpolating the full composed
matrix. This lets Core Animation interpolate raw angle values correctly, enabling seamless infinite rotation loops.
Changes
individual key paths on first mount
'reverse')
Simulator.Screen.Recording.-.iPhone.17.Pro.-.2026-04-01.at.19.03.31.mov