fix : 필터링 로직 ver2.5로 변경#24
Open
zwo-n wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경점 👍
ScoreWeightEnum배점 수정MatchScoreService정부/시중은행 가중치 분리 처리 및 점수 로직 추가RateCalculatorService그룹1/2/3 분류 및 그룹별 로직 추가SearchService거주 지역 필터링 product_keyword기반 변경버그 해결 💊
MatchScoreService에서 bankCondScore계산 시 GOV_DEPOSIT 키로 잘못 참조하던 버그 수정스크린샷 🖼
기본 상황
결과
{ { "governmentRanked": [ { "productId": 2, "productName": "청년내일채움공제", "source": "ONTONG", "totalScore": 100.0, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 52.94, "depositScore": 47.06, "bankCondScore": 0.0 }, { "productId": 3, "productName": "청년우대형 청약통장", "source": "ONTONG", "totalScore": 60.29, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 13.24, "depositScore": 47.06, "bankCondScore": 0.0 } ], "bankRanked": [ { "productId": 1, "productName": "e-쎄이프 정기예금", "source": "FSS", "totalScore": 85.0, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 10.0, "depositScore": 75.0, "bankCondScore": 0.0 }, { "productId": 4, "productName": "청년우대적금", "source": "FSS", "totalScore": 85.0, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 10.0, "depositScore": 75.0, "bankCondScore": 0.0 } ], "rateRanked": [ { "productId": 2, "productName": "청년내일채움공제", "source": "ONTONG", "baseRate": 10.0, "achievableRate": 10.0, "isSubscription": false, "subscriptionNote": null }, { "productId": 4, "productName": "청년우대적금", "source": "FSS", "baseRate": 3.8, "achievableRate": 4.5, "isSubscription": false, "subscriptionNote": null }, { "productId": 1, "productName": "e-쎄이프 정기예금", "source": "FSS", "baseRate": 3.45, "achievableRate": 3.45, "isSubscription": false, "subscriptionNote": null } ], "subscriptionProducts": [ { "productId": 3, "productName": "청년우대형 청약통장", "source": "ONTONG", "baseRate": null, "achievableRate": null, "isSubscription": true, "subscriptionNote": "청약: 금리 비교 대상 아님" } ] } }저축기간 1년 선택 ( PeriodScore 부분 점수 )
{ "governmentRanked": [ { "productId": 2, "productName": "청년내일채움공제", "source": "ONTONG", "totalScore": 60.294117647058826, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 13.23529411764706, "depositScore": 47.05882352941177, "bankCondScore": 0.0 }, { "productId": 3, "productName": "청년우대형 청약통장", "source": "ONTONG", "totalScore": 60.294117647058826, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 13.23529411764706, "depositScore": 47.05882352941177, "bankCondScore": 0.0 } ], "bankRanked": [ { "productId": 1, "productName": "e-쎄이프 정기예금", "source": "FSS", "totalScore": 85.0, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 10.0, "depositScore": 75.0, "bankCondScore": 0.0 }, { "productId": 4, "productName": "청년우대적금", "source": "FSS", "totalScore": 85.0, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 10.0, "depositScore": 75.0, "bankCondScore": 0.0 } ], "rateRanked": [ { "productId": 2, "productName": "청년내일채움공제", "source": "ONTONG", "baseRate": 10.0, "achievableRate": 10.0, "isSubscription": false, "subscriptionNote": null }, { "productId": 3, "productName": "청년우대형 청약통장", "source": "ONTONG", "baseRate": 4.5, "achievableRate": 4.5, "isSubscription": false, "subscriptionNote": null }, { "productId": 4, "productName": "청년우대적금", "source": "FSS", "baseRate": 3.8, "achievableRate": 4.5, "isSubscription": false, "subscriptionNote": null }, { "productId": 1, "productName": "e-쎄이프 정기예금", "source": "FSS", "baseRate": 3.45, "achievableRate": 3.45, "isSubscription": false, "subscriptionNote": null } ], "subscriptionProducts": [] }납입 한도 초과 (depositScore 감점 확인)
{ "governmentRanked": [], "bankRanked": [ { "productId": 1, "productName": "e-쎄이프 정기예금", "source": "FSS", "totalScore": 85.0, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 10.0, "depositScore": 75.0, "bankCondScore": 0.0 } ], "rateRanked": [ { "productId": 1, "productName": "e-쎄이프 정기예금", "source": "FSS", "baseRate": 3.45, "achievableRate": 3.45, "isSubscription": false, "subscriptionNote": null } ], "subscriptionProducts": [] }군복무 신분 선택 (identityScore 변경 확인)
{ "governmentRanked": [], "bankRanked": [ { "productId": 1, "productName": "e-쎄이프 정기예금", "source": "FSS", "totalScore": 85.0, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 10.0, "depositScore": 75.0, "bankCondScore": 0.0 }, { "productId": 4, "productName": "청년우대적금", "source": "FSS", "totalScore": 85.0, "benefitScore": 0.0, "periodScore": 0.0, "identityScore": 10.0, "depositScore": 75.0, "bankCondScore": 0.0 } ], "rateRanked": [ { "productId": 4, "productName": "청년우대적금", "source": "FSS", "baseRate": 3.8, "achievableRate": 4.5, "isSubscription": false, "subscriptionNote": null }, { "productId": 1, "productName": "e-쎄이프 정기예금", "source": "FSS", "baseRate": 3.45, "achievableRate": 3.45, "isSubscription": false, "subscriptionNote": null } ], "subscriptionProducts": [] }비고 ✏
테스트 시, 예외 상황은 잘 처리되는 것으로 확인되오나, product_keyword 벨유가 포함되어 있지 않아 정확한 테스트 결과라고 보기에는 한계가 있을 듯 합니다...
편하게 코멘트 남겨주세요!