feat/week2#19
Open
parkganghyun123-sketch wants to merge 5 commits into
Open
Conversation
yeochaeeon
reviewed
May 1, 2026
| fun GreetingPreview() { | ||
| AndroidstudyTheme { | ||
| Greeting("박강현") | ||
| LazyColumn( |
Collaborator
There was a problem hiding this comment.
LazyColumn 의 어떤 이점 때문에 Column이 아닌 LazyColumn을 사용하였나요?
두 요소 간 어떤 차이가 있는지 생각해보면 좋을 것 같습니다.
데이터가 많아진다면, 어떤 것이 더 유리할까요??
| colors = CardDefaults.cardColors(containerColor = Color.White), | ||
| elevation = CardDefaults.cardElevation(defaultElevation = 4.dp) | ||
| ) { | ||
| Column { |
Collaborator
There was a problem hiding this comment.
피드 영역을 각각 작은 Composable로 분리해보면 가독성과 재사용성이 좋아질 것 같습니다! (아래는 컴포저블 분리 예시 입니다, 꼭 이렇게 할 필요는 없어요)
- PostItem: 카드 전체
- PostHeader: 프로필 이미지 + 유저네임
- PostActions: 좋아요/공유 아이콘 영역
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
변경점 👍
새로 구현한 기능 및 주요 변경점
버그 해결 💊
해결한 버그
테스트 💻
변경점을 테스트하기 위한 방법 기술
스크린샷 🖼
변경된 부분에 대한 스크린샷
비고 ✏
리뷰어에게 전하는 말 등
사용하지 않은 항목은 모두 지워주세요.