Skip to content

Update README, versioning, and improve workflow and code readability#110

Merged
abearab merged 11 commits intoArcInstitute:mainfrom
FunGI-cap:dev
Mar 6, 2026
Merged

Update README, versioning, and improve workflow and code readability#110
abearab merged 11 commits intoArcInstitute:mainfrom
FunGI-cap:dev

Conversation

@abearab
Copy link
Collaborator

@abearab abearab commented Mar 5, 2026

No description provided.

and update authors in pyproject.toml
Refactor mapped reads calculations to simplify code and improve readability.
Update GitHub Actions workflow to remove master branch support and improve caching for pip dependencies
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the Polars DataFrame operations within the cas9.py module to enhance performance and readability. It streamlines the calculation of various read mapping and recombination percentages by replacing inefficient conversions to Pandas DataFrames and redundant fillna(0) calls with direct and optimized Polars expressions, making the code cleaner and more efficient.

Highlights

  • Polars Optimization: Optimized Polars DataFrame operations for calculating mapped read percentages, unmapped read percentages, and recombination event percentages.
  • Code Readability: Improved code readability by simplifying data aggregation expressions within Polars, removing unnecessary conversions to Pandas DataFrames.
  • Efficiency: Removed redundant fillna(0) calls and intermediate to_pandas() conversions, leading to more efficient data processing.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • screenpro/ngs/cas9.py
    • Updated map_to_library_single_guide to use direct Polars .sum() for count aggregation, removing to_pandas().fillna(0).sum() and int(res.select(pl.sum("count")).to_pandas()['count']).
    • Modified map_to_library_dual_guide to optimize mapped and unmapped read percentage calculations using native Polars methods, replacing Pandas conversions.
    • Streamlined recombination event percentage calculation in map_to_library_dual_guide by removing intermediate Pandas conversions and fillna(0).
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/python-package.yml
Activity
  • No specific activity (comments, reviews) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Remove pip cache configuration from Python workflow
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request improves the code by replacing several inefficient to_pandas() conversions with direct polars operations for calculations. This is a great change for performance and code clarity. My review focuses on further improving the readability of the new code by suggesting formatting changes that align with Python's standard style guide (PEP 8), specifically regarding line wrapping within function calls. The functional changes themselves are correct and a good improvement.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Collaborator Author

@abearab abearab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@abearab abearab merged commit 18279da into ArcInstitute:main Mar 6, 2026
1 check passed
@abearab abearab deleted the dev branch March 6, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant