Open
Conversation
2 tasks
Contributor
There was a problem hiding this comment.
Hey - 我发现了 1 个问题,并留下了一些整体反馈:
- 示例中使用了
env命令,它是 POSIX 特有的;请考虑简要说明这种方式需要类 Unix 的 shell,并在适用时为 Windows 用户提供或链接到替代方案。 - 由于示例中直接包含了一个 API token,建议添加一条简短说明,提醒用户不要在配置中硬编码真实密钥,并将这些值视为敏感信息。
给 AI 代理的提示词
Please address the comments from this code review:
## Overall Comments
- The example uses the `env` command, which is POSIX-specific; consider briefly noting that this approach requires a Unix-like shell and suggesting or linking to an alternative for Windows users if applicable.
- Since the example includes an API token inline, it may be worth adding a short note reminding users not to hardcode real secrets in config and to treat these values as sensitive.
## Individual Comments
### Comment 1
<location> `en/use/mcp.md:75` </location>
<code_context>
}
```
+If the MCP server you need requires environment variables to configure something (e.g. access token), you could use commandline tool `env`:
+
+```json
</code_context>
<issue_to_address>
**suggestion (typo):** Consider changing “commandline tool” to “command-line tool” for correct wording.
You could also make it read more naturally as “command-line tool `env`”.
```suggestion
If the MCP server you need requires environment variables to configure something (e.g. access token), you could use the command-line tool `env`:
```
</issue_to_address>帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've found 1 issue, and left some high level feedback:
- The example uses the
envcommand, which is POSIX-specific; consider briefly noting that this approach requires a Unix-like shell and suggesting or linking to an alternative for Windows users if applicable. - Since the example includes an API token inline, it may be worth adding a short note reminding users not to hardcode real secrets in config and to treat these values as sensitive.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The example uses the `env` command, which is POSIX-specific; consider briefly noting that this approach requires a Unix-like shell and suggesting or linking to an alternative for Windows users if applicable.
- Since the example includes an API token inline, it may be worth adding a short note reminding users not to hardcode real secrets in config and to treat these values as sensitive.
## Individual Comments
### Comment 1
<location> `en/use/mcp.md:75` </location>
<code_context>
}
```
+If the MCP server you need requires environment variables to configure something (e.g. access token), you could use commandline tool `env`:
+
+```json
</code_context>
<issue_to_address>
**suggestion (typo):** Consider changing “commandline tool” to “command-line tool” for correct wording.
You could also make it read more naturally as “command-line tool `env`”.
```suggestion
If the MCP server you need requires environment variables to configure something (e.g. access token), you could use the command-line tool `env`:
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
在英文和中文使用指南中说明如何配置需要环境变量的 MCP 服务器。
文档:
env命令传递环境变量。env工具为 MCP 服务器进行基于环境变量的配置。Original summary in English
Summary by Sourcery
Document how to configure MCP servers that require environment variables in both English and Chinese usage guides.
Documentation:
envcommand to pass environment variables when running an MCP server.envtool.