Skip to content

Fix/stale command hints#8245

Open
lingyun14beta wants to merge 5 commits into
AstrBotDevs:masterfrom
lingyun14beta:fix/stale-command-hints
Open

Fix/stale command hints#8245
lingyun14beta wants to merge 5 commits into
AstrBotDevs:masterfrom
lingyun14beta:fix/stale-command-hints

Conversation

@lingyun14beta
Copy link
Copy Markdown
Contributor

@lingyun14beta lingyun14beta commented May 19, 2026

fix #8043
v4.23.0 移除了大量内置指令,但部分日志和配置提示仍引用了需安装扩展指令的插件/不存在的指令(/t2i/switch/wl/tool off_all),改为引导用户使用 /new 或前往 WebUI 操作。


Modifications / 改动点

  • result_decorate/stage.py/t2i → WebUI
  • builtin_stars/astrbot/main.py/switch/new
  • core/config/default.py/wl → WebUI
  • core/provider/sources/openai_source.py/tool off_all → WebUI
  • This is NOT a breaking change. / 这不是一个破坏性变更。

Screenshots or Test Results / 运行截图或测试结果

这是一个日志改动)


Checklist / 检查清单

  • 😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
    / 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。

  • 👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
    / 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”

  • 🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in requirements.txt and pyproject.toml.
    / 我确保没有引入新依赖库,或者引入了新依赖库的同时将其添加到 requirements.txtpyproject.toml 文件相应位置。

  • 😮 My changes do not introduce malicious code.
    / 我的更改没有引入恶意代码。

Summary by Sourcery

Bug Fixes:

  • Correct stale log and configuration hints that referenced removed or unavailable commands for session switching, whitelisting, text-to-image, and tool disabling.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. area:core The bug / feature is about astrbot's core, backend labels May 19, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • For the new WebUI guidance messages, consider adding more specific navigation paths (e.g., exact menu names or tabs) so users can quickly locate the relevant settings without guesswork.
  • In openai_source.py, the case where the model does not support tools may be more of a user-actionable warning than a hard error; consider using logger.warning to better reflect severity and avoid alarming logs for expected misconfigurations.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- For the new WebUI guidance messages, consider adding more specific navigation paths (e.g., exact menu names or tabs) so users can quickly locate the relevant settings without guesswork.
- In `openai_source.py`, the case where the model does not support tools may be more of a user-actionable warning than a hard error; consider using `logger.warning` to better reflect severity and avoid alarming logs for expected misconfigurations.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several user-facing log messages and configuration hints to guide users toward the WebUI instead of deprecated CLI commands. Feedback includes identifying dead code in openai_source.py due to a redundant error check and a recommendation to update internationalization files to ensure consistency across translations.

Comment thread astrbot/core/provider/sources/openai_source.py Outdated
Comment thread astrbot/core/config/default.py
@dosubot dosubot Bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:core The bug / feature is about astrbot's core, backend size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]WARN提示不正确

1 participant