Skip to content

chore: Fix order for workbook categories (#3325)#3339

Merged
KATO-Hiro merged 1 commit intostagingfrom
#3325
Mar 31, 2026
Merged

chore: Fix order for workbook categories (#3325)#3339
KATO-Hiro merged 1 commit intostagingfrom
#3325

Conversation

@KATO-Hiro
Copy link
Copy Markdown
Collaborator

@KATO-Hiro KATO-Hiro commented Mar 31, 2026

close #3325

Summary by CodeRabbit

  • その他
    • 内部コードの構成を改善しました。

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1687c339-757a-42eb-802a-29511fa74ce5

📥 Commits

Reviewing files that changed from the base of the PR and between ad6f2b2 and eba247e.

📒 Files selected for processing (1)
  • src/features/workbooks/types/workbook_placement.ts

📝 Walkthrough

Walkthrough

workbook_placement.tsSolutionCategorySOLUTION_LABELS定数内のプロパティ順序を変更。DATA_STRUCTUREを前に移動し、ANALYSISOTHERSの順序を入れ替え。キーと値の変更なし。

Changes

Cohort / File(s) Summary
プロパティ順序の変更
src/features/workbooks/types/workbook_placement.ts
SolutionCategorySOLUTION_LABELSの定数オブジェクト内のプロパティ順序を再配列。DATA_STRUCTURESEARCH_SIMULATIONの前に配置し、ANALYSISOTHERSの相対位置を切り替え。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

順序が変わって、
解法もすっきり🔄
認識に合わせ、
ユーザーを笑顔に✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed PRのタイトルは「chore: Fix order for workbook categories」であり、変更内容である「SolutionCategoryとSOLUTION_LABELSの定数オブジェクト内のプロパティ順序の並び替え」を正確に反映している。
Linked Issues check ✅ Passed PR#3325の目的は「学習順序と一般的な認識に合わせた問題集カテゴリの並び順修正」であり、変更内容である「DATA_STRUCTUREを前方へ、ANALYSISとOTHERSの相対的な順序を入れ替え」はこの目的を満たしている。
Out of Scope Changes check ✅ Passed 変更は単一ファイル(workbook_placement.ts)の定数オブジェクトのプロパティ順序のみを対象とし、キーや値は変更されていないため、スコープ外の変更は見当たらない。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch #3325

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Collaborator Author

@KATO-Hiro KATO-Hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KATO-Hiro KATO-Hiro merged commit 32ff5f0 into staging Mar 31, 2026
3 checks passed
@KATO-Hiro KATO-Hiro deleted the #3325 branch March 31, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UI/UX] 問題集一覧・解法別の表示の並び順、表記を修正しましょう

1 participant