Open
Conversation
The IB device name may exceeds original 12 bytes, for example a RXE device: rxe_enp161s0np0 (16 bytes with null terminated) then atop will read the truncated path: /sys/class/infiniband/rxe_enp161s/ports/1/rate however the correct path is: /sys/class/infiniband/rxe_enp161s0np0/ports/1/rate So atop fails to get the real rate, and set rate field to 0. Commit 19e7bbe("Avoid divide by zero when InfiniBand rate is 0") fixed the bottom part of *using* rate, and this change fixes the top part of *collecting* rate. Signed-off-by: zhenwei pi <zhenwei.pi@linux.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The IB device name may exceeds original 12 bytes, for example a RXE device: rxe_enp161s0np0 (16 bytes with null terminated) then atop will read the truncated path:
/sys/class/infiniband/rxe_enp161s/ports/1/rate
however the correct path is:
/sys/class/infiniband/rxe_enp161s0np0/ports/1/rate
So atop fails to get the real rate, and set rate field to 0. Commit 19e7bbe("Avoid divide by zero when InfiniBand rate is 0") fixed the bottom part of using rate, and this change fixes the top part of collecting rate.